govau/performance-dashboard

View on GitHub
client/src/_shared/utils/proposedApiChanges.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function getWidgetType has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

export const getWidgetType = widget => {
  const { type, options } = widget;

  if (type === 'fact') {
    return 'fact';
Severity: Minor
Found in client/src/_shared/utils/proposedApiChanges.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function getWidgetType has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const getWidgetType = widget => {
  const { type, options } = widget;

  if (type === 'fact') {
    return 'fact';
Severity: Minor
Found in client/src/_shared/utils/proposedApiChanges.js - About 1 hr to fix

    Avoid too many return statements within this function.
    Open

        return 'sparkline';
    Severity: Major
    Found in client/src/_shared/utils/proposedApiChanges.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

          return 'hero';
      Severity: Major
      Found in client/src/_shared/utils/proposedApiChanges.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return 'line';
        Severity: Major
        Found in client/src/_shared/utils/proposedApiChanges.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

            return;
          Severity: Major
          Found in client/src/_shared/utils/proposedApiChanges.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

              return;
            Severity: Major
            Found in client/src/_shared/utils/proposedApiChanges.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return;
              Severity: Major
              Found in client/src/_shared/utils/proposedApiChanges.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                    return 'donut';
                Severity: Major
                Found in client/src/_shared/utils/proposedApiChanges.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                      return 'kpi-count';
                  Severity: Major
                  Found in client/src/_shared/utils/proposedApiChanges.js - About 30 mins to fix

                    Function getWidgetOptions has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                    Open

                    export const getWidgetOptions = widget => {
                      let res = {};
                    
                      const { options } = widget;
                    
                    
                    Severity: Minor
                    Found in client/src/_shared/utils/proposedApiChanges.js - About 25 mins to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    There are no issues that match your filters.

                    Category
                    Status