Sign upLogin

graph-algorithm/maximum-matching

View on GitHub
Star
src/core/blossom/blossom.js

Summary

Maintainability
F
2 wks
Test Coverage

Function blossom has a Cognitive Complexity of 375 (exceeds 5 allowed). Consider refactoring.
Open

export function blossom(CHECK_OPTIMUM, CHECK_DELTA) {
    // Check delta2/delta3 computation after every substage;
    // only works on integer weights, slows down the algorithm to O(n^4).
    if (CHECK_DELTA === undefined) CHECK_DELTA = false;
Severity: Minor
Found in src/core/blossom/blossom.js - About 1 wk to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function blossom has 563 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function blossom(CHECK_OPTIMUM, CHECK_DELTA) {
    // Check delta2/delta3 computation after every substage;
    // only works on integer weights, slows down the algorithm to O(n^4).
    if (CHECK_DELTA === undefined) CHECK_DELTA = false;
Severity: Major
Found in src/core/blossom/blossom.js - About 2 days to fix

    Function maxWeightMatching has 558 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        const maxWeightMatching = (edges, maxCardinality = false) => {
        // Vertices are numbered 0 .. (nvertex-1).
        // Non-trivial blossoms are numbered nvertex .. (2*nvertex-1)
        //
        // Edges are numbered 0 .. (nedge-1).
    Severity: Major
    Found in src/core/blossom/blossom.js - About 2 days to fix

      File blossom.js has 576 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import assert from 'assert';

import {blossomEdges} from './blossomEdges.js';
import {blossomLeaves} from './blossomLeaves.js';
import {checkDelta2} from './checkDelta2.js';
      Severity: Major
      Found in src/core/blossom/blossom.js - About 1 day to fix

        Function addBlossom has 102 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                const addBlossom = (base, k) => {
            let v = edges[k][0];
            let w = edges[k][1];
            const bb = inblossom[base];
            let bv = inblossom[v];
        Severity: Major
        Found in src/core/blossom/blossom.js - About 4 hrs to fix

          Function expandBlossom has 78 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                  const expandBlossom = (b, endstage) => {
            console.debug(
                'DEBUG: expandBlossom(' + b + ',' + endstage + ') ' + blossomchilds[b],
            );
            // Convert sub-blossoms into top-level blossoms.
          Severity: Major
          Found in src/core/blossom/blossom.js - About 3 hrs to fix

            Function augmentBlossom has 45 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    const augmentBlossom = (b, v) => {
            console.debug('DEBUG: augmentBlossom(' + b + ',' + v + ')');
            // Bubble up through the blossom tree from vertex v to an immediate
            // sub-blossom of b.
            let j;
            Severity: Minor
            Found in src/core/blossom/blossom.js - About 1 hr to fix

              Function scanBlossom has 30 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      const scanBlossom = (v, w) => {
            console.debug('DEBUG: scanBlossom(' + v + ',' + w + ')');
            // Trace back from v and w, placing breadcrumbs as we go.
            const path = [];
            let base = -1;
              Severity: Minor
              Found in src/core/blossom/blossom.js - About 1 hr to fix

                Avoid deeply nested control flow statements.
                Open

                                        if (label[b] === 1) {
                            // Top-level S-blossom: z = z + 2*delta
                            dualvar[b] += delta;
                        } else if (label[b] === 2) {
                            // Top-level T-blossom: z = z - 2*delta
                Severity: Major
                Found in src/core/blossom/blossom.js - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if (deltatype === -1 || d < delta) {
                            delta = d;
                            deltatype = 3;
                            deltaedge = bestedge[b];
                        }
                  Severity: Major
                  Found in src/core/blossom/blossom.js - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                            if (inblossom[v] === inblossom[w]) {
                            // This edge is internal to a blossom; ignore it
                            continue;
                        }
                    Severity: Major
                    Found in src/core/blossom/blossom.js - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if (allowedge[k]) {
                            if (label[inblossom[w]] === 0) {
                                // (C1) w is a free vertex;
                                // label w with T and label its mate with S (R12).
                                assignLabel(w, 2, p ^ 1);
                      Severity: Major
                      Found in src/core/blossom/blossom.js - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if (!allowedge[k]) {
                            kslack = slack(k);
                            if (kslack <= 0) {
                                // Edge k has zero slack => it is allowable
                                allowedge[k] = true;
                        Severity: Major
                        Found in src/core/blossom/blossom.js - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if (deltatype === -1 || d < delta) {
                            delta = d;
                            deltatype = 2;
                            deltaedge = bestedge[v];
                        }
                          Severity: Major
                          Found in src/core/blossom/blossom.js - About 45 mins to fix

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                checkDelta3({
                        nvertex,
                        edges,
                        blossomparent,
                        blossomchilds,
                            Severity: Major
                            Found in src/core/blossom/blossom.js and 1 other location - About 1 hr to fix
                            src/core/blossom/blossom.js on lines 926..937

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 58.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                        verifyOptimum({
                nvertex,
                edges,
                maxCardinality,
                nedge,
                            Severity: Major
                            Found in src/core/blossom/blossom.js and 1 other location - About 1 hr to fix
                            src/core/blossom/blossom.js on lines 782..793

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 58.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                            assert(
                    label[bv] === 2 ||
                        (label[bv] === 1 && labelend[bv] === mate[blossombase[bv]]),
                );
                            Severity: Minor
                            Found in src/core/blossom/blossom.js and 1 other location - About 40 mins to fix
                            src/core/blossom/blossom.js on lines 322..325

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 49.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                            assert(
                    label[bw] === 2 ||
                        (label[bw] === 1 && labelend[bw] === mate[blossombase[bw]]),
                );
                            Severity: Minor
                            Found in src/core/blossom/blossom.js and 1 other location - About 40 mins to fix
                            src/core/blossom/blossom.js on lines 301..304

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 49.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                    if (deltatype === -1 || d < delta) {
                            delta = d;
                            deltatype = 3;
                            deltaedge = bestedge[b];
                        }
                            Severity: Minor
                            Found in src/core/blossom/blossom.js and 1 other location - About 35 mins to fix
                            src/core/blossom/blossom.js on lines 807..811

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            Similar blocks of code found in 2 locations. Consider refactoring.
                            Open

                                                    if (deltatype === -1 || d < delta) {
                            delta = d;
                            deltatype = 2;
                            deltaedge = bestedge[v];
                        }
                            Severity: Minor
                            Found in src/core/blossom/blossom.js and 1 other location - About 35 mins to fix
                            src/core/blossom/blossom.js on lines 821..825

                            Duplicated Code

                            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                            Tuning

                            This issue has a mass of 46.

                            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                            Refactorings

                            Further Reading

                            There are no issues that match your filters.

                            Category
                            Status