grommet/grommet-ferret

View on GitHub
src/js/components/virtualMachine/VirtualMachineEditNetwork.js

Summary

Maintainability
D
2 days
Test Coverage

Function render has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  render () {
    const { network, errors } = this.state;
    let removeControl;
    if (this.props.onRemove) {
      removeControl = (
Severity: Major
Found in src/js/components/virtualMachine/VirtualMachineEditNetwork.js - About 2 hrs to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

      _onChange (event) {
        var network = { ...this.state.network };
        var errors = { ...this.state.errors };
        const attribute = event.target.getAttribute('name');
        const value = event.target.value;
    src/js/components/image/ImageForm.js on lines 63..71
    src/js/components/settings/AccountEdit.js on lines 43..51
    src/js/components/settings/DirectoryEdit.js on lines 173..181

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 123.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

            <FormField key="ipV4Address" htmlFor="ipV4Address" label="IPv4 address"
              error={errors.ipV4Address} >
              <input id="ipV4Address" name="ipV4Address" type="text"
                value={network.ipV4Address} onChange={this._onChange} />
            </FormField>,
    src/js/components/settings/AccountEdit.js on lines 61..67
    src/js/components/settings/AccountEdit.js on lines 68..74
    src/js/components/settings/HypervisorEdit.js on lines 110..114
    src/js/components/settings/HypervisorEdit.js on lines 115..119
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 107..111
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 112..116
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 117..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

            <FormField key="ipV6Address" htmlFor="ipV6Address" label="IPv6 address"
              error={errors.ipV6Address} >
              <input id="ipV4Address" name="ipV6Address" type="text"
                value={network.ipV6Address} onChange={this._onChange} />
            </FormField>
    src/js/components/settings/AccountEdit.js on lines 61..67
    src/js/components/settings/AccountEdit.js on lines 68..74
    src/js/components/settings/HypervisorEdit.js on lines 110..114
    src/js/components/settings/HypervisorEdit.js on lines 115..119
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 102..106
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 107..111
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 112..116

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

            <FormField key="ipV4Netmask" htmlFor="ipV4Netmask" label="IPv4 netmask"
              error={errors.ipV4Netmask} >
              <input id="ipV4Netmask" name="ipV4Netmask" type="text"
                value={network.ipV4Netmask} onChange={this._onChange} />
            </FormField>,
    src/js/components/settings/AccountEdit.js on lines 61..67
    src/js/components/settings/AccountEdit.js on lines 68..74
    src/js/components/settings/HypervisorEdit.js on lines 110..114
    src/js/components/settings/HypervisorEdit.js on lines 115..119
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 102..106
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 112..116
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 117..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 8 locations. Consider refactoring.
    Open

            <FormField key="ipV4Gateway" htmlFor="ipV4Gateway" label="IPv4 gateway"
              error={errors.ipV4Gateway} >
              <input id="ipV4Gateway" name="ipV4Gateway" type="text"
                value={network.ipV4Gateway} onChange={this._onChange} />
            </FormField>,
    src/js/components/settings/AccountEdit.js on lines 61..67
    src/js/components/settings/AccountEdit.js on lines 68..74
    src/js/components/settings/HypervisorEdit.js on lines 110..114
    src/js/components/settings/HypervisorEdit.js on lines 115..119
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 102..106
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 107..111
    src/js/components/virtualMachine/VirtualMachineEditNetwork.js on lines 117..121

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 83.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        const networkSuggestions = nextProps.networks.map((network) => {
          return {
            network: network,
            label: <NetworkSuggestion name={network.name} vLanId={network.vLanId} />
          };
    Severity: Minor
    Found in src/js/components/virtualMachine/VirtualMachineEditNetwork.js and 1 other location - About 45 mins to fix
    src/js/components/dashboard/Dashboard.js on lines 80..87

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 50.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status