grommet/grommet

View on GitHub
src/js/components/Data/stories/SpaceX.js

Summary

Maintainability
F
3 days
Test Coverage

Function SpaceX has 48 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export const SpaceX = () => {
  const [total, setTotal] = useState(0);
  const [result, setResult] = useState({ data: [] });
  const [rockets, setRockets] = useState([]);
  const [view, setView] = useState(defaultView);
Severity: Minor
Found in src/js/components/Data/stories/SpaceX.js - About 1 hr to fix

    Function fetchLaunches has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    const fetchLaunches = async (view) => {
      const query = buildQuery(view);
      const sort = {
        [view?.sort?.property || 'name']: view?.sort?.direction || 'asc',
      };
    Severity: Minor
    Found in src/js/components/Data/stories/SpaceX.js - About 1 hr to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

      const fetchLaunches = async (view) => {
        const query = buildQuery(view);
        const sort = {
          [view?.sort?.property || 'name']: view?.sort?.direction || 'asc',
        };
      Severity: Major
      Found in src/js/components/Data/stories/SpaceX.js and 1 other location - About 1 day to fix
      src/js/components/Data/stories/OnSelect.js on lines 30..58

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 201.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

      const buildQuery = (view) => {
        const query = {};
        const properties = view?.properties || [];
        Object.keys(properties).forEach((property) => {
          switch (property) {
      Severity: Major
      Found in src/js/components/Data/stories/SpaceX.js and 2 other locations - About 7 hrs to fix
      src/js/components/Data/stories/Infinite.js on lines 7..28
      src/js/components/Data/stories/OnSelect.js on lines 7..28

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 188.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        useEffect(() => {
          fetchLaunches(view).then((response) => {
            setResult({
              data: response.docs,
              filteredTotal: response.totalDocs,
      Severity: Major
      Found in src/js/components/Data/stories/SpaceX.js and 1 other location - About 3 hrs to fix
      src/js/components/Data/stories/OnSelect.js on lines 146..158

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 103.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

      const fetchRockets = async () => {
        const body = {
          options: {
            sort: { name: 'asc' },
            select: ['name', 'id'],
      Severity: Major
      Found in src/js/components/Data/stories/SpaceX.js and 2 other locations - About 3 hrs to fix
      src/js/components/Data/stories/Infinite.js on lines 59..73
      src/js/components/Data/stories/OnSelect.js on lines 60..74

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 102.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            <Data
              properties={{
                rocket: { label: 'Rocket', options: rockets },
                success: { label: 'Success', options: ['Successful', 'Failed'] },
              }}
      Severity: Major
      Found in src/js/components/Data/stories/SpaceX.js and 1 other location - About 3 hrs to fix
      src/js/components/Data/stories/OnSelect.js on lines 169..194

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        useEffect(() => {
          fetchRockets().then((response) =>
            setRockets(
              response.docs.map(({ name, id }) => ({ value: id, label: name })),
            ),
      Severity: Major
      Found in src/js/components/Data/stories/SpaceX.js and 1 other location - About 1 hr to fix
      src/js/components/Data/stories/OnSelect.js on lines 138..144

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 73.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status