Sign upLogin

grommet/grommet

View on GitHub
Star
src/js/components/DataTable/stories/InfiniteScrollDataTable.js

Summary

Maintainability
F
1 wk
Test Coverage

File InfiniteScrollDataTable.js has 324 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import React from 'react';

import { Box, DataTable, Heading, Meter, Text } from 'grommet';

const amountFormatter = new Intl.NumberFormat('en-US', {
Severity: Minor
Found in src/js/components/DataTable/stories/InfiniteScrollDataTable.js - About 3 hrs to fix

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    const DATA = [
  {
    key: 1,
    name: 'Ilana',
    location: 'Bay Area',
    Severity: Major
    Found in src/js/components/DataTable/stories/InfiniteScrollDataTable.js and 1 other location - About 5 days to fix
    src/js/components/DataTable/stories/Show.js on lines 59..300

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 968.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 2 locations. Consider refactoring.
    Open

    const columns = [
  {
    property: 'key',
    header: 'Key',
    primary: true,
    Severity: Major
    Found in src/js/components/DataTable/stories/InfiniteScrollDataTable.js and 1 other location - About 1 day to fix
    src/js/components/DataTable/stories/Show.js on lines 11..57

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 304.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

          <Heading level={3}>
        <Box gap="small">
          <strong>InfiniteScroll embedded in DataTable</strong>
          <Text>
            Scroll down to load more data, open console to see loading info
    Severity: Major
    Found in src/js/components/DataTable/stories/InfiniteScrollDataTable.js and 1 other location - About 1 hr to fix
    src/js/components/Table/stories/InfiniteScrollInTable.js on lines 32..39

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 63.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status