groundtruth/PoziMobile

View on GitHub
js/pages/Details.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function initForm has 41 lines of code (exceeds 25 allowed). Consider refactoring.
Open

        this.initForm = function(feature) {
            incomingFeature = feature;

            var formFields;

Severity: Minor
Found in js/pages/Details.js - About 1 hr to fix

    Function update has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            this.update = function(feature) {
                that.initForm(feature);
                that.initButtons({
                    delete: function() {
                        if (confirm("Are you sure you want to delete this record?")) {
    Severity: Minor
    Found in js/pages/Details.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                              syncher.persist({
                                  restEndpoint: layerOptions.restEndpoint,
                                  action: "delete",
                                  data: updatedGeoFeature(),
                                  id: combinedHash()[layerOptions.idField]
      Severity: Minor
      Found in js/pages/Details.js and 1 other location - About 45 mins to fix
      js/pages/Details.js on lines 168..173

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                          syncher.persist({
                              restEndpoint: layerOptions.restEndpoint,
                              action: "update",
                              data: updatedGeoFeature(),
                              id: combinedHash()[layerOptions.idField]
      Severity: Minor
      Found in js/pages/Details.js and 1 other location - About 45 mins to fix
      js/pages/Details.js on lines 157..162

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 50.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status