Sign upLogin

gschorkopf/frolfr

View on GitHub
Star

Showing 3 of 5 total issues

Method us_options has 54 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def self.us_options
    [
      ['Alabama', 'AL'],
      ['Alaska', 'AK'],
      ['Arizona', 'AZ'],
Severity: Major
Found in app/models/states.rb - About 2 hrs to fix

    Method recent_rounds_notification has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def self.recent_rounds_notification
    rounds = Round.where(created_at: 24.hours.ago..Time.now)

    return if rounds.empty?
    Severity: Major
    Found in app/models/slack_bot.rb - About 2 hrs to fix

      Method recent_rounds_notification has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

        def self.recent_rounds_notification
    rounds = Round.where(created_at: 24.hours.ago..Time.now)

    return if rounds.empty?
      Severity: Minor
      Found in app/models/slack_bot.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language