guibranco/BancosBrasileiros

View on GitHub
schemas/javascript.js

Summary

Maintainability
D
2 days
Test Coverage

Function transform has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

function transform(val, typ, getProps) {
    function transformPrimitive(typ, val) {
        if (typeof typ === typeof val) return val;
        return invalidValue(typ, val);
    }
Severity: Minor
Found in schemas/javascript.js - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function transform has 67 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function transform(val, typ, getProps) {
    function transformPrimitive(typ, val) {
        if (typeof typ === typeof val) return val;
        return invalidValue(typ, val);
    }
Severity: Major
Found in schemas/javascript.js - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

        if (Array.isArray(typ)) return transformEnum(typ, val);
    Severity: Major
    Found in schemas/javascript.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return typ.hasOwnProperty("unionMembers") ? transformUnion(typ.unionMembers, val)
                  : typ.hasOwnProperty("arrayItems")    ? transformArray(typ.arrayItems, val)
                  : typ.hasOwnProperty("props")         ? transformObject(getProps(typ), typ.additional, val)
                  : invalidValue(typ, val);
      Severity: Major
      Found in schemas/javascript.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            if (typ === Date && typeof val !== "number") return transformDate(val);
        Severity: Major
        Found in schemas/javascript.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return transformPrimitive(typ, val);
          Severity: Major
          Found in schemas/javascript.js - About 30 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function jsToJSONProps(typ) {
                if (typ.jsToJSON === undefined) {
                    const map = {};
                    typ.props.forEach((p) => map[p.js] = { key: p.json, typ: p.typ });
                    typ.jsToJSON = map;
            Severity: Major
            Found in schemas/javascript.js and 1 other location - About 3 hrs to fix
            schemas/javascript.js on lines 24..31

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

            function jsonToJSProps(typ) {
                if (typ.jsonToJS === undefined) {
                    const map = {};
                    typ.props.forEach((p) => map[p.json] = { key: p.js, typ: p.typ });
                    typ.jsonToJS = map;
            Severity: Major
            Found in schemas/javascript.js and 1 other location - About 3 hrs to fix
            schemas/javascript.js on lines 33..40

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 100.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status