Sign upLogin

guyellis/nth-day

View on GitHub
Star

Showing 4 of 4 total issues

Function nthDay has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

export function nthDay(nth, dayOfWeek, relevantDateParam, afterDayParam) {
  const relevantDate = dateFromDate(relevantDateParam);
  const month = relevantDate.month();
  const year = relevantDate.year();
  const afterDay = afterDayParam || 0;
Severity: Minor
Found in src/nth-day.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function nthDay has 26 lines of code (exceeds 25 allowed). Consider refactoring.
Open

export function nthDay(nth, dayOfWeek, relevantDateParam, afterDayParam) {
  const relevantDate = dateFromDate(relevantDateParam);
  const month = relevantDate.month();
  const year = relevantDate.year();
  const afterDay = afterDayParam || 0;
Severity: Minor
Found in src/nth-day.js - About 1 hr to fix

    Function dateFromDate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

    function dateFromDate(date) {
  if (!date) {
    return moment();
  }
    Severity: Minor
    Found in src/nth-day.js - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function dayFromString has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

    function dayFromString(dayOfWeek) {
  if (typeof dayOfWeek === 'string') {
    const dow = dayOfWeek.toLowerCase().slice(0, 3);
    const weekDays = ['sun', 'mon', 'tue', 'wed', 'thu', 'fri', 'sat'];
    const dayNumber = weekDays.indexOf(dow);
    Severity: Minor
    Found in src/nth-day.js - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language