hackedteam/core-blackberry

View on GitHub

Showing 1,573 of 2,662 total issues

Method fixDupInstruction has 191 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    private void fixDupInstruction(Clazz         clazz,
                                   CodeAttribute codeAttribute,
                                   int           dupOffset,
                                   Instruction   instruction)
    {

    ClassUtil has 53 methods (exceeds 20 allowed). Consider refactoring.
    Open

    public class ClassUtil
    {
        private static final String EMPTY_STRING = "";
    
    
    
    Severity: Major
    Found in bb-tools/proguard4.7/src/proguard/classfile/util/ClassUtil.java - About 7 hrs to fix

      File ConstantPoolEditor.java has 478 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
       * ProGuard -- shrinking, optimization, obfuscation, and preverification
       *             of Java bytecode.
       *
       * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)

        File InstructionSequenceMatcher.java has 476 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*
         * ProGuard -- shrinking, optimization, obfuscation, and preverification
         *             of Java bytecode.
         *
         * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)

          AppListener has 52 methods (exceeds 20 allowed). Consider refactoring.
          Open

          public final class AppListener extends Listener implements RadioStatusListener,
                  HolsterListener, SystemListener2, PhoneListener, PhoneLogListener,
                  iSingleton {
          
              private static final long GUID = 0x4e5dd52b9f50b3feL;
          Severity: Major
          Found in RCSBlackBerry/src/blackberry/AppListener.java - About 7 hrs to fix

            Method getProGuardConfiguration has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
            Open

                private Configuration getProGuardConfiguration()
                {
                    Configuration configuration = new Configuration();
            
                    // Get the input and output jars and directories.
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/gui/ProGuardGUI.java - About 7 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method buildFilter has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
            Open

                private void buildFilter(String       prefix,
                                         StringBuffer positive,
                                         StringBuffer negative)
                {
                    int positiveCount = 0;
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/gui/FilterBuilder.java - About 7 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method originalMethodName has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
            Open

                private void originalMethodName(String       className,
                                                String       obfuscatedMethodName,
                                                int          lineNumber,
                                                String       type,
                                                String       arguments,
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/retrace/ReTrace.java - About 7 hrs to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method execute has 181 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public void execute() throws IOException
                {
                    // Read the mapping file.
                    MappingReader mappingReader = new MappingReader(mappingFile);
                    mappingReader.pump(this);
            Severity: Major
            Found in bb-tools/proguard4.7/src/proguard/retrace/ReTrace.java - About 7 hrs to fix

              Method evaluateSingleInstructionBlock has 180 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private void evaluateSingleInstructionBlock(Clazz            clazz,
                                                              Method           method,
                                                              CodeAttribute    codeAttribute,
                                                              TracedVariables  variables,
                                                              TracedStack      stack,

                File InjectorManager.java has 464 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                //#preprocess
                
                /* *************************************************
                 * Copyright (c) 2010 - 2012
                 * HT srl,   All rights reserved.
                Severity: Minor
                Found in RCSBlackBerry/src/blackberry/injection/InjectorManager.java - About 7 hrs to fix

                  ConstantPoolShrinker has 50 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  public class ConstantPoolShrinker
                  extends      SimplifiedVisitor
                  implements   ClassVisitor,
                               MemberVisitor,
                               ConstantVisitor,

                    Method parseMemberSpecificationArguments has 174 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        private void parseMemberSpecificationArguments(String             externalClassName,
                                                                       ClassSpecification classSpecification)
                        throws ParseException, IOException
                        {
                            // Clear the annotation name.
                    Severity: Major
                    Found in bb-tools/proguard4.7/src/proguard/ConfigurationParser.java - About 6 hrs to fix

                      File CodeAttributeComposer.java has 455 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /*
                       * ProGuard -- shrinking, optimization, obfuscation, and preverification
                       *             of Java bytecode.
                       *
                       * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)

                        JSONObject has 49 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        public class JSONObject {
                        
                            /**
                             * JSONObject.NULL is equivalent to the value that JavaScript calls null,
                             * whilst Java's null is equivalent to the value that JavaScript calls
                        Severity: Minor
                        Found in RCSBlackBerry/src/rpc/json/me/JSONObject.java - About 6 hrs to fix

                          Method execute has a Cognitive Complexity of 44 (exceeds 5 allowed). Consider refactoring.
                          Open

                              public void execute() throws IOException
                              {
                                  // Read the mapping file.
                                  MappingReader mappingReader = new MappingReader(mappingFile);
                                  mappingReader.pump(this);
                          Severity: Minor
                          Found in bb-tools/proguard4.7/src/proguard/retrace/ReTrace.java - About 6 hrs to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          File ConfigurationWriter.java has 447 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          /*
                           * ProGuard -- shrinking, optimization, obfuscation, and preverification
                           *             of Java bytecode.
                           *
                           * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
                          Severity: Minor
                          Found in bb-tools/proguard4.7/src/proguard/ConfigurationWriter.java - About 6 hrs to fix

                            File Utils.java has 446 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            //#preprocess
                            /* *************************************************
                             * Copyright (c) 2010 - 2010
                             * HT srl,   All rights reserved.
                             * Project      : RCS, RCSBlackBerry_lib
                            Severity: Minor
                            Found in RCSBlackBerry/src/blackberry/utils/Utils.java - About 6 hrs to fix

                              Utils has 47 methods (exceeds 20 allowed). Consider refactoring.
                              Open

                              public final class Utils {
                              
                                  /** The debug instance. */
                                  //#ifdef DEBUG
                                  private static Debug debug = new Debug("Utils", DebugLevel.INFORMATION);
                              Severity: Minor
                              Found in RCSBlackBerry/src/blackberry/utils/Utils.java - About 6 hrs to fix

                                Method exploreField has a Cognitive Complexity of 42 (exceeds 5 allowed). Consider refactoring.
                                Open

                                    protected void exploreField(Field field, int deep, String[] history,
                                            Debug debug) {
                                
                                        String tab = "";
                                
                                

                                Cognitive Complexity

                                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                A method's cognitive complexity is based on a few simple rules:

                                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                • Code is considered more complex for each "break in the linear flow of the code"
                                • Code is considered more complex when "flow breaking structures are nested"

                                Further reading

                                Severity
                                Category
                                Status
                                Source
                                Language