hackedteam/core-blackberry

View on GitHub

Showing 1,573 of 2,662 total issues

File OverrideGraphics2D.java has 434 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/gui/splash/OverrideGraphics2D.java - About 6 hrs to fix

    File Utils.java has 434 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    //#preprocess
    /* *************************************************
     * Copyright (c) 2010 - 2010
     * HT srl,   All rights reserved.
     * Project      : RCS, RCSBlackBerry_lib
    Severity: Minor
    Found in InjectionFramework/src/blackberry/utils/Utils.java - About 6 hrs to fix

      CodeAttributeEditor has 46 methods (exceeds 20 allowed). Consider refactoring.
      Open

      public class CodeAttributeEditor
      extends      SimplifiedVisitor
      implements   AttributeVisitor,
                   InstructionVisitor,
                   ExceptionInfoVisitor,

        File ProgramClass.java has 430 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        /*
         * ProGuard -- shrinking, optimization, obfuscation, and preverification
         *             of Java bytecode.
         *
         * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 6 hrs to fix

          Method execute has a Cognitive Complexity of 41 (exceeds 5 allowed). Consider refactoring.
          Open

              public void execute(ClassPool programClassPool) throws IOException
              {
                  ClassPath programJars = configuration.programJars;
          
                  // Perform a check on the first jar.
          Severity: Minor
          Found in bb-tools/proguard4.7/src/proguard/OutputWriter.java - About 6 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File Evidence.java has 426 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          //#preprocess
          /* *************************************************
           * Copyright (c) 2010 - 2010
           * HT srl,   All rights reserved.
           * Project      : RCS, RCSBlackBerry_lib
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/evidence/Evidence.java - About 6 hrs to fix

            File ProgramClassWriter.java has 425 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            /*
             * ProGuard -- shrinking, optimization, obfuscation, and preverification
             *             of Java bytecode.
             *
             * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)

              Utils has 45 methods (exceeds 20 allowed). Consider refactoring.
              Open

              public final class Utils {
              
                  /** The debug instance. */
                  //#ifdef DEBUG
                  private static Debug debug = new Debug("Utils", DebugLevel.INFORMATION);
              Severity: Minor
              Found in InjectionFramework/src/blackberry/utils/Utils.java - About 6 hrs to fix

                Method isVariableInitializationNecessary has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
                Open

                    private boolean isVariableInitializationNecessary(Clazz         clazz,
                                                                      Method        method,
                                                                      CodeAttribute codeAttribute,
                                                                      int           initializationOffset,
                                                                      int           variableIndex)

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                File InstructionConstants.java has 419 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                /*
                 * ProGuard -- shrinking, optimization, obfuscation, and preverification
                 *             of Java bytecode.
                 *
                 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)

                  Consider simplifying this complex logical expression.
                  Open

                          if (// Only inline the method if it is private, static, or final.
                              (accessFlags & (ClassConstants.INTERNAL_ACC_PRIVATE |
                                              ClassConstants.INTERNAL_ACC_STATIC  |
                                              ClassConstants.INTERNAL_ACC_FINAL)) != 0                              &&
                  
                  
                  Severity: Critical
                  Found in bb-tools/proguard4.7/src/proguard/optimize/peephole/MethodInliner.java - About 6 hrs to fix

                    Method lookForPinMessages has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                    Open

                        private Date lookForPinMessages(final Message[] messages)
                                throws MessagingException {
                    
                            //#ifdef DEBUG
                            debug.trace("lookForPinMessages on: " + messages.length);
                    Severity: Minor
                    Found in RCSBlackBerry/src/blackberry/module/mail/MailListener.java - About 5 hrs to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method visitConstantInstruction has a Cognitive Complexity of 39 (exceeds 5 allowed). Consider refactoring.
                    Open

                        public void visitConstantInstruction(Clazz clazz, Method method, CodeAttribute codeAttribute, int offset, ConstantInstruction constantInstruction)
                        {
                            int constantIndex = constantInstruction.constantIndex;
                    
                            // Get information on the called class and method, if present.

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    JSONArray has 43 methods (exceeds 20 allowed). Consider refactoring.
                    Open

                    public class JSONArray {
                    
                        /**
                         * The Vector where the JSONArray's properties are kept.
                         */
                    Severity: Minor
                    Found in RCSBlackBerry/src/rpc/json/me/JSONArray.java - About 5 hrs to fix

                      LibraryClass has 43 methods (exceeds 20 allowed). Consider refactoring.
                      Open

                      public class LibraryClass implements Clazz
                      {
                          public int             u2accessFlags;
                          public String          thisClassName;
                          public String          superClassName;
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/classfile/LibraryClass.java - About 5 hrs to fix

                        Method exploreField has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                        Open

                            protected void exploreField(Field field, int deep, String[] history,
                                    Debug debug) {
                        
                                String tab = "";
                        
                        
                        Severity: Minor
                        Found in RCSBlackBerry/src/blackberry/injection/FieldExplorer.java - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method nextClean has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
                        Open

                            public char nextClean() throws JSONException {
                                for (;;) {
                                    char c = next();
                                    if (c == '/') {
                                        switch (next()) {
                        Severity: Minor
                        Found in RCSBlackBerry/src/rpc/json/me/JSONTokener.java - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Status has 42 methods (exceeds 20 allowed). Consider refactoring.
                        Open

                        public final class Status implements iSingleton {
                        
                            /** The debug instance. */
                            //#ifdef DEBUG
                            private static Debug debug = new Debug("Status", DebugLevel.VERBOSE);
                        Severity: Minor
                        Found in RCSBlackBerry/src/blackberry/Status.java - About 5 hrs to fix

                          DoubleValue has 42 methods (exceeds 20 allowed). Consider refactoring.
                          Open

                          public abstract class DoubleValue extends Category2Value
                          {
                              /**
                               * Returns the specific double value, if applicable.
                               */
                          Severity: Minor
                          Found in bb-tools/proguard4.7/src/proguard/evaluation/value/DoubleValue.java - About 5 hrs to fix

                            FloatValue has 42 methods (exceeds 20 allowed). Consider refactoring.
                            Open

                            public abstract class FloatValue extends Category1Value
                            {
                                /**
                                 * Returns the specific float value, if applicable.
                                 */
                            Severity: Minor
                            Found in bb-tools/proguard4.7/src/proguard/evaluation/value/FloatValue.java - About 5 hrs to fix
                              Severity
                              Category
                              Status
                              Source
                              Language