Sign upLogin

hackedteam/core-blackberry

View on GitHub
Star

Showing 1,573 of 2,662 total issues

EvaluationShrinker has 42 methods (exceeds 20 allowed). Consider refactoring.
Open

public class EvaluationShrinker
extends      SimplifiedVisitor
implements   AttributeVisitor
{
    //*
Severity: Minor
Found in bb-tools/proguard4.7/src/proguard/optimize/evaluation/EvaluationShrinker.java - About 5 hrs to fix

    File ConstantPoolRemapper.java has 402 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
    Severity: Minor
    Found in bb-tools/proguard4.7/src/proguard/classfile/editor/ConstantPoolRemapper.java - About 5 hrs to fix

      Method matchStar has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
      Open

          static boolean matchStar(String wildcardProcess, String processName) {

        if (processName == null) {
            return (wildcardProcess == null);
        }
      Severity: Minor
      Found in RCSBlackBerry/src/blackberry/event/EventProcess.java - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method traverseField has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
      Open

          public static void traverseField(Field field, int deep,
            FieldChangeListener fieldChangeListener) {

        fieldChangeListener.fieldChanged(field, deep);
        if (field instanceof Manager) {
      Severity: Minor
      Found in InjectionFramework/src/blackberry/injection/FieldExplorer.java - About 5 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File IntegerValue.java has 397 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
      Severity: Minor
      Found in bb-tools/proguard4.7/src/proguard/evaluation/value/IntegerValue.java - About 5 hrs to fix

        ProgramClass has 41 methods (exceeds 20 allowed). Consider refactoring.
        Open

        public class ProgramClass implements Clazz
{
    public int             u4magic;
    public int             u4version;
    public int             u2constantPoolCount;
        Severity: Minor
        Found in bb-tools/proguard4.7/src/proguard/classfile/ProgramClass.java - About 5 hrs to fix

          Method inject has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
          Open

              private boolean inject(AInjector injector) {
        //#ifdef DEBUG
        debug.trace("injectAll " + injector);
        //#endif
          Severity: Minor
          Found in RCSBlackBerry/src/blackberry/injection/InjectorManager.java - About 5 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          File item.rb has 391 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'mongoid'

require_relative '../build'
require_relative '../push'
          Severity: Minor
          Found in server/item.rb - About 5 hrs to fix

            ParticularLongValue has 40 methods (exceeds 20 allowed). Consider refactoring.
            Open

            final class ParticularLongValue extends SpecificLongValue
{
    private final long value;
            Severity: Minor
            Found in bb-tools/proguard4.7/src/proguard/evaluation/value/ParticularLongValue.java - About 5 hrs to fix

              Method generalize has 132 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  public ReferenceValue generalize(ReferenceValue other)
    {
        // If both types are identical, the generalization is the same too.
        if (this.equals(other))
        {
              Severity: Major
              Found in bb-tools/proguard4.7/src/proguard/evaluation/value/ReferenceValue.java - About 5 hrs to fix

                Method nextValue has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                Open

                    public Object nextValue() throws JSONException {
        char c = nextClean();
        String s;

        switch (c) {
                Severity: Minor
                Found in RCSBlackBerry/src/rpc/json/me/JSONTokener.java - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method originalFieldName has a Cognitive Complexity of 35 (exceeds 5 allowed). Consider refactoring.
                Open

                    private void originalFieldName(String       className,
                                   String       obfuscatedFieldName,
                                   String       type,
                                   StringBuffer outLine,
                                   List         extraOutLines)
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/retrace/ReTrace.java - About 5 hrs to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                SpecificLongValue has 39 methods (exceeds 20 allowed). Consider refactoring.
                Open

                abstract class SpecificLongValue extends LongValue
{
    // Implementations of unary methods of LongValue.

    public LongValue negate()
                Severity: Minor
                Found in bb-tools/proguard4.7/src/proguard/evaluation/value/SpecificLongValue.java - About 5 hrs to fix

                  InstructionSequenceMatcher has 39 methods (exceeds 20 allowed). Consider refactoring.
                  Open

                  public class InstructionSequenceMatcher
extends      SimplifiedVisitor
implements   InstructionVisitor,
             ConstantVisitor
{
                  Severity: Minor
                  Found in bb-tools/proguard4.7/src/proguard/classfile/util/InstructionSequenceMatcher.java - About 5 hrs to fix

                    Method actualStart has 128 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                        public void actualStart() {
        boolean ret = true;

        Device device = Device.getInstance();
        final StringBuffer sb = new StringBuffer();
                    Severity: Major
                    Found in RCSBlackBerry/src/blackberry/module/ModuleDevice.java - About 5 hrs to fix

                      File CodePreverifier.java has 380 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
                      Severity: Minor
                      Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 5 hrs to fix

                        Method readEmailBody has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private void readEmailBody(final MimeBodyPart mbp) {
        //#ifdef DEBUG
        debug.trace("readEmailBody: MimeBodyPart");
        //#endif
        //Extract the content of the message.
                        Severity: Minor
                        Found in RCSBlackBerry/src/blackberry/module/mail/MailParser.java - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method parseClassPathArgument has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private ClassPath parseClassPathArgument(ClassPath classPath,
                                             boolean   isOutput)
    throws ParseException, IOException
    {
        // Create a new List if necessary.
                        Severity: Minor
                        Found in bb-tools/proguard4.7/src/proguard/ConfigurationParser.java - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method insertPopInstructions has a Cognitive Complexity of 34 (exceeds 5 allowed). Consider refactoring.
                        Open

                            private void insertPopInstructions(int offset, boolean replace, int popCount)
    {
        // Mark this instruction.
        markInstruction(offset);
                        Severity: Minor
                        Found in bb-tools/proguard4.7/src/proguard/optimize/evaluation/EvaluationShrinker.java - About 5 hrs to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        File LibraryClass.java has 376 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        /*
 * ProGuard -- shrinking, optimization, obfuscation, and preverification
 *             of Java bytecode.
 *
 * Copyright (c) 2002-2011 Eric Lafortune (eric@graphics.cornell.edu)
                        Severity: Minor
                        Found in bb-tools/proguard4.7/src/proguard/classfile/LibraryClass.java - About 5 hrs to fix
                          Severity
                          Category
                          Status
                          Source
                          Language