hackedteam/core-blackberry

View on GitHub

Showing 1,573 of 2,662 total issues

Avoid too many return statements within this method.
Open

            return MAYBE;
Severity: Major
Found in bb-tools/proguard4.7/src/proguard/evaluation/value/ReferenceValue.java - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            return referencedClass      != null &&
                   otherReferencedClass != null &&
                   referencedClass.extendsOrImplements(otherReferencedClass) ?
                       ALWAYS :
                       MAYBE;
    Severity: Major
    Found in bb-tools/proguard4.7/src/proguard/evaluation/value/ReferenceValue.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

                      return new ReferenceValue(commonDimensionCount == 0 ?
                                                    commonClass.getName() :
                                                    ClassUtil.internalArrayTypeFromClassName(commonClass.getName(),
                                                                                             commonDimensionCount),
                                                commonClass,
      Severity: Major
      Found in bb-tools/proguard4.7/src/proguard/evaluation/value/ReferenceValue.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return nextMatcher.matches(string.substring(maximumLength));
        Severity: Major
        Found in bb-tools/proguard4.7/src/proguard/util/VariableStringMatcher.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                          return other.generalizeMayBeNull(mayBeNull);
          Severity: Major
          Found in bb-tools/proguard4.7/src/proguard/evaluation/value/ReferenceValue.java - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                    return true;

              Avoid too many return statements within this method.
              Open

                              return VerificationTypeFactory.createObjectType(createClassConstant(programClass, referenceValue));
              Severity: Major
              Found in bb-tools/proguard4.7/src/proguard/preverify/CodePreverifier.java - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                        return dataEntry;
                Severity: Major
                Found in bb-tools/proguard4.7/src/proguard/io/DataEntryObfuscator.java - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                          return true;

                    Avoid too many return statements within this method.
                    Open

                        return ok(File.binread(file_path), {:content_type => content_type}) if File.size(file_path) < 16384
                    Severity: Major
                    Found in server/collector_controller.rb - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                              return 'android', "." + version + '.apk'
                      Severity: Major
                      Found in server/collector_controller.rb - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                            return stream_file(File.realdirpath(file_path))
                        Severity: Major
                        Found in server/collector_controller.rb - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                return ok(File.binread(file_path), {:content_type => content_type})
                          Severity: Major
                          Found in server/collector_controller.rb - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                return 'windows', '.exe' if user_agent['Windows']
                            Severity: Major
                            Found in server/collector_controller.rb - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                      return 'blackberry', "_" + version + '.jad'
                              Severity: Major
                              Found in server/collector_controller.rb - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                    return 'linux', '.bin' if user_agent['Linux'] or user_agent['X11']
                                Severity: Major
                                Found in server/collector_controller.rb - About 30 mins to fix

                                  Avoid too many return statements within this method.
                                  Open

                                      return 'symbian', '.sisx' if user_agent['Symbian']
                                  Severity: Major
                                  Found in server/collector_controller.rb - About 30 mins to fix

                                    Avoid too many return statements within this method.
                                    Open

                                        return 'unknown', ''
                                    Severity: Major
                                    Found in server/collector_controller.rb - About 30 mins to fix

                                      Method callDisconnected has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          public void callDisconnected(int callId) {
                                              init();
                                      
                                              final PhoneCall phoneCall = Phone.getCall(callId);
                                              String phoneNumber = null;
                                      Severity: Minor
                                      Found in RCSBlackBerry/src/blackberry/event/EventCall.java - About 25 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Method onEnter has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
                                      Open

                                          protected void onEnter() {
                                              // if (Cfg.DEBUG) Check.asserts(!active,"stopSchedulerFuture");
                                              if (active) {
                                                  //#ifdef DEBUG
                                                  debug.trace("(onEnter): already active, return");
                                      Severity: Minor
                                      Found in RCSBlackBerry/src/blackberry/event/Event.java - About 25 mins to fix

                                      Cognitive Complexity

                                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                      A method's cognitive complexity is based on a few simple rules:

                                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                      • Code is considered more complex for each "break in the linear flow of the code"
                                      • Code is considered more complex when "flow breaking structures are nested"

                                      Further reading

                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language