hackedteam/core-blackberry

View on GitHub

Showing 1,089 of 2,662 total issues

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        for (int i = 0; i < wantedPermissions.length; i++) {
            final int perm = wantedPermissions[i];
            permRequest.addPermission(perm);
        }
Severity: Minor
Found in RCSBlackBerry/src/blackberry/Core.java and 2 other locations - About 30 mins to fix
InjectionFramework/src/blackberry/InjectionFrameworkApp.java on lines 375..378
RCSBlackBerry/src/blackberry/evidence/Markup.java on lines 379..382

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        for (int i = 0; i < wantedPermissions.length; i++) {
            final int perm = wantedPermissions[i];
            permRequest.addPermission(perm);
        }
Severity: Minor
Found in InjectionFramework/src/blackberry/InjectionFrameworkApp.java and 2 other locations - About 30 mins to fix
RCSBlackBerry/src/blackberry/Core.java on lines 191..194
RCSBlackBerry/src/blackberry/evidence/Markup.java on lines 379..382

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (DEBUG)
        {
            System.out.println("UnreachableCodeRemover: "+clazz.getName()+"."+method.getName(clazz)+method.getDescriptor(clazz));
        }
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java on lines 131..134
bb-tools/proguard4.7/src/proguard/classfile/editor/CodeAttributeEditor.java on lines 327..330

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            for(int i = 0; i<size; i++){
                String value = buffer.readUTF();
                array[i]=value;
            }
Severity: Minor
Found in RCSBlackBerry/src/blackberry/evidence/Markup.java and 1 other location - About 30 mins to fix
bb-tools/proguard4.7/src/proguard/classfile/editor/InterfaceSorter.java on lines 115..120

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        } else if (res == Proto.NO) {
            //#ifdef DEBUG
            debug.error("checkOk: NO"); //$NON-NLS-1$
            //#endif
            return false;
RCSBlackBerry/src/blackberry/action/sync/protocol/ZProtocol.java on lines 665..675
RCSBlackBerry/src/blackberry/action/sync/protocol/ZProtocol.java on lines 724..734

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public IntegerValue compare(ParticularFloatValue other)
    {
        return this.value <  other.value ? SpecificValueFactory.INTEGER_VALUE_M1 :
               this.value == other.value ? SpecificValueFactory.INTEGER_VALUE_0  :
                                           SpecificValueFactory.INTEGER_VALUE_1;
bb-tools/proguard4.7/src/proguard/evaluation/value/ParticularDoubleValue.java on lines 180..185

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    protected void setFieldValue(Clazz       clazz,
                                 RefConstant refConstant,
                                 Value       value)
    {
        if (storeFieldValues)
bb-tools/proguard4.7/src/proguard/optimize/evaluation/StoringInvocationUnit.java on lines 72..84

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

        for (int index = 0; index < count; index++)
        {
            String internalType = internalTypeEnumeration.nextType();

            internalTypes[index] = internalType;
RCSBlackBerry/src/blackberry/evidence/Markup.java on lines 362..365

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public void annotationsAccept(Clazz clazz, Method method, AnnotationVisitor annotationVisitor)
    {
        for (int index = 0; index < u2annotationsCount; index++)
        {
            // We don't need double dispatching here, since there is only one
bb-tools/proguard4.7/src/proguard/classfile/attribute/annotation/AnnotationsAttribute.java on lines 77..85

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 3 locations. Consider refactoring.
Open

        if (DEBUG)
        {
            System.out.println("CodeAttributeEditor: "+clazz.getName()+"."+method.getName(clazz)+method.getDescriptor(clazz));
        }
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/StackSizeComputer.java on lines 131..134
bb-tools/proguard4.7/src/proguard/optimize/peephole/UnreachableCodeRemover.java on lines 106..109

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 42.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitSourceFileAttribute(Clazz clazz, SourceFileAttribute sourceFileAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitSourceFileAttribute(clazz, sourceFileAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void paint(Graphics graphics, long time)
    {
        // Draw the sprites.
        for (int index = 0; index < sprites.length; index++)
        {
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitSourceDirAttribute(Clazz clazz, SourceDirAttribute sourceDirAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitSourceDirAttribute(clazz, sourceDirAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitSignatureAttribute(Clazz clazz, SignatureAttribute syntheticAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitSignatureAttribute(clazz, syntheticAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitRuntimeVisibleAnnotationsAttribute(Clazz clazz, RuntimeVisibleAnnotationsAttribute runtimeVisibleAnnotationsAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitRuntimeVisibleAnnotationsAttribute(clazz, runtimeVisibleAnnotationsAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitUnknownAttribute(Clazz clazz, UnknownAttribute unknownAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitUnknownAttribute(clazz, unknownAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitSyntheticAttribute(Clazz clazz, SyntheticAttribute syntheticAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitSyntheticAttribute(clazz, syntheticAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitInnerClassesAttribute(Clazz clazz, InnerClassesAttribute innerClassesAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitInnerClassesAttribute(clazz, innerClassesAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitDeprecatedAttribute(Clazz clazz, DeprecatedAttribute deprecatedAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitDeprecatedAttribute(clazz, deprecatedAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 295..301
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 12 locations. Consider refactoring.
Open

    public void visitRuntimeInvisibleAnnotationsAttribute(Clazz clazz, RuntimeInvisibleAnnotationsAttribute runtimeInvisibleAnnotationsAttribute)
    {
        for (int index = 0; index < attributeVisitors.length; index++)
        {
            attributeVisitors[index].visitRuntimeInvisibleAnnotationsAttribute(clazz, runtimeInvisibleAnnotationsAttribute);
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 79..85
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 88..94
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 97..103
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 106..112
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 115..121
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 124..130
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 133..139
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 142..148
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 151..157
bb-tools/proguard4.7/src/proguard/classfile/attribute/visitor/MultiAttributeVisitor.java on lines 286..292
bb-tools/proguard4.7/src/proguard/gui/splash/CompositeSprite.java on lines 48..55

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 41.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Severity
Category
Status
Source
Language