hackedteam/vector-edk

View on GitHub

Showing 9,525 of 13,510 total issues

File EdkIIWorkspaceBuild.py has 853 lines of code (exceeds 250 allowed). Consider refactoring.
Open

## @file
# This file is used to define each component of the build database
#
# Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
# This program and the accompanying materials
Severity: Major
Found in BaseTools/Source/Python/Common/EdkIIWorkspaceBuild.py - About 2 days to fix

    File GenMake.py has 845 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    ## @file
    # Create makefile for MS nmake and GNU make
    #
    # Copyright (c) 2007 - 2010, Intel Corporation. All rights reserved.<BR>
    # This program and the accompanying materials
    Severity: Major
    Found in BaseTools/Source/Python/AutoGen/GenMake.py - About 2 days to fix

      File ftplib.py has 845 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      """An FTP client class and some helper functions.
      
      Based on RFC 959: File Transfer Protocol (FTP), by J. Postel and J. Reynolds
      
      Example:
      Severity: Major
      Found in AppPkg/Applications/Python/Python-2.7.2/Lib/ftplib.py - About 2 days to fix

        File ftplib.py has 845 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        """An FTP client class and some helper functions.
        
        Based on RFC 959: File Transfer Protocol (FTP), by J. Postel and J. Reynolds
        
        Example:
        Severity: Major
        Found in vector-uefi/fd/efi/StdLib/lib/python.27/ftplib.py - About 2 days to fix

          File cgi.py has 840 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          #! /usr/local/bin/python
          
          # NOTE: the above "/usr/local/bin/python" is NOT a mistake.  It is
          # intentionally NOT "/usr/bin/env python".  On many systems
          # (e.g. Solaris), /usr/local/bin is not in $PATH as passed to CGI
          Severity: Major
          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/cgi.py - About 2 days to fix

            File cgi.py has 840 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            #! /usr/local/bin/python
            
            # NOTE: the above "/usr/local/bin/python" is NOT a mistake.  It is
            # intentionally NOT "/usr/bin/env python".  On many systems
            # (e.g. Solaris), /usr/local/bin is not in $PATH as passed to CGI
            Severity: Major
            Found in vector-uefi/fd/efi/StdLib/lib/python.27/cgi.py - About 2 days to fix

              File ElementTree.py has 837 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              #
              # ElementTree
              # $Id: ElementTree.py 3440 2008-07-18 14:45:01Z fredrik $
              #
              # light-weight XML support for Python 2.3 and later.
              Severity: Major
              Found in AppPkg/Applications/Python/Python-2.7.2/Lib/xml/etree/ElementTree.py - About 2 days to fix

                File ElementTree.py has 837 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                #
                # ElementTree
                # $Id: ElementTree.py 3440 2008-07-18 14:45:01Z fredrik $
                #
                # light-weight XML support for Python 2.3 and later.
                Severity: Major
                Found in vector-uefi/fd/efi/StdLib/lib/python.27/xml/etree/ElementTree.py - About 2 days to fix

                  Function _GetModuleLibraryInstances has a Cognitive Complexity of 100 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def _GetModuleLibraryInstances(Module, Platform, BuildDatabase, Arch, Target, Toolchain):
                      ModuleType = Module.ModuleType
                  
                      # for overriding library instances with module specific setting
                      PlatformModule = Platform.Modules[str(Module)]
                  Severity: Minor
                  Found in BaseTools/Source/Python/Workspace/WorkspaceCommon.py - About 2 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function ApplyLibraryInstance has a Cognitive Complexity of 100 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def ApplyLibraryInstance(self, Module):
                          ModuleType = Module.ModuleType
                  
                          # for overridding library instances with module specific setting
                          PlatformModule = self.Platform.Modules[str(Module)]
                  Severity: Minor
                  Found in BaseTools/Source/Python/AutoGen/AutoGen.py - About 2 days to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Consider simplifying this complex logical expression.
                  Open

                                  if LA90 == IDENTIFIER:
                                      LA90 = self.input.LA(2)
                                      if LA90 == 25 or LA90 == 29 or LA90 == 30 or LA90 == 31 or LA90 == 32 or LA90 == 33 or LA90 == 34 or LA90 == 35 or LA90 == 36 or LA90 == 37 or LA90 == 38 or LA90 == 39 or LA90 == 40 or LA90 == 41 or LA90 == 42 or LA90 == 45 or LA90 == 46 or LA90 == 47 or LA90 == 48 or LA90 == 49 or LA90 == 50 or LA90 == 51 or LA90 == 52 or LA90 == 53 or LA90 == 54 or LA90 == 55 or LA90 == 56 or LA90 == 57 or LA90 == 58 or LA90 == 59 or LA90 == 60 or LA90 == 61:
                                          alt90 = 1
                                      elif LA90 == 62:
                  Severity: Critical
                  Found in BaseTools/Source/Python/Ecc/CParser.py - About 2 days to fix

                    Consider simplifying this complex logical expression.
                    Open

                                        if LA95 == IDENTIFIER:
                                            LA95 = self.input.LA(2)
                                            if LA95 == 62:
                                                LA95_46 = self.input.LA(3)
                    
                    Severity: Critical
                    Found in BaseTools/Source/Python/Ecc/CParser.py - About 2 days to fix

                      Consider simplifying this complex logical expression.
                      Open

                                      if LA90 == IDENTIFIER:
                                          LA90 = self.input.LA(2)
                                          if LA90 == 25 or LA90 == 29 or LA90 == 30 or LA90 == 31 or LA90 == 32 or LA90 == 33 or LA90 == 34 or LA90 == 35 or LA90 == 36 or LA90 == 37 or LA90 == 38 or LA90 == 39 or LA90 == 40 or LA90 == 41 or LA90 == 42 or LA90 == 45 or LA90 == 46 or LA90 == 47 or LA90 == 48 or LA90 == 49 or LA90 == 50 or LA90 == 51 or LA90 == 52 or LA90 == 53 or LA90 == 54 or LA90 == 55 or LA90 == 56 or LA90 == 57 or LA90 == 58 or LA90 == 59 or LA90 == 60 or LA90 == 61:
                                              alt90 = 1
                                          elif LA90 == 62:
                      Severity: Critical
                      Found in BaseTools/Source/Python/Eot/CParser.py - About 2 days to fix

                        Consider simplifying this complex logical expression.
                        Open

                                            if LA95 == IDENTIFIER:
                                                LA95 = self.input.LA(2)
                                                if LA95 == 62:
                                                    LA95_46 = self.input.LA(3)
                        
                        Severity: Critical
                        Found in BaseTools/Source/Python/Eot/CParser.py - About 2 days to fix

                          Function generate_tokens has a Cognitive Complexity of 98 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def generate_tokens(readline):
                              """
                              The generate_tokens() generator requires one argment, readline, which
                              must be a callable object which provides the same interface as the
                              readline() method of built-in file objects. Each call to the function
                          Severity: Minor
                          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/lib2to3/pgen2/tokenize.py - About 1 day to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          Function generate_tokens has a Cognitive Complexity of 98 (exceeds 5 allowed). Consider refactoring.
                          Open

                          def generate_tokens(readline):
                              """
                              The generate_tokens() generator requires one argment, readline, which
                              must be a callable object which provides the same interface as the
                              readline() method of built-in file objects. Each call to the function
                          Severity: Minor
                          Found in vector-uefi/fd/efi/StdLib/lib/python.27/lib2to3/pgen2/tokenize.py - About 1 day to fix

                          Cognitive Complexity

                          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                          A method's cognitive complexity is based on a few simple rules:

                          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                          • Code is considered more complex for each "break in the linear flow of the code"
                          • Code is considered more complex when "flow breaking structures are nested"

                          Further reading

                          CodeGenerator has 102 functions (exceeds 20 allowed). Consider refactoring.
                          Open

                          class CodeGenerator:
                              """Defines basic code generator for Python bytecode
                          
                              This class is an abstract base class.  Concrete subclasses must
                              define an __init__() that defines self.graph and then calls the
                          Severity: Major
                          Found in AppPkg/Applications/Python/Python-2.7.2/Lib/compiler/pycodegen.py - About 1 day to fix

                            CodeGenerator has 102 functions (exceeds 20 allowed). Consider refactoring.
                            Open

                            class CodeGenerator:
                                """Defines basic code generator for Python bytecode
                            
                                This class is an abstract base class.  Concrete subclasses must
                                define an __init__() that defines self.graph and then calls the
                            Severity: Major
                            Found in vector-uefi/fd/efi/StdLib/lib/python.27/compiler/pycodegen.py - About 1 day to fix

                              File ccompiler.py has 816 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              """distutils.ccompiler
                              
                              Contains CCompiler, an abstract base class that defines the interface
                              for the Distutils compiler abstraction model."""
                              
                              Severity: Major
                              Found in AppPkg/Applications/Python/Python-2.7.2/Lib/distutils/ccompiler.py - About 1 day to fix

                                File ccompiler.py has 816 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                """distutils.ccompiler
                                
                                Contains CCompiler, an abstract base class that defines the interface
                                for the Distutils compiler abstraction model."""
                                
                                Severity: Major
                                Found in vector-uefi/fd/efi/StdLib/lib/python.27/distutils/ccompiler.py - About 1 day to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language