Avoid deeply nested control flow statements.

Open

                        if (Item.ToolChainFamily, Item.ToolChain) not in Pb.BuildOptions:
                            Pb.BuildOptions[(Item.ToolChainFamily, Item.ToolChain)] = Item.Option
                        else:
                            OptionString = Pb.BuildOptions[(Item.ToolChainFamily, Item.ToolChain)]
                            Pb.BuildOptions[(Item.ToolChainFamily, Item.ToolChain)] = OptionString + " " + Item.Option

Avoid deeply nested control flow statements.

Open

                        if Arch in Item.SupArchList:
                            for ModuleType in Item.SupModuleList:
                                EdkLogger.debug(EdkLogger.DEBUG_3, "\tLibraryClass %s has specific defined module types" % Name)
                                if ModuleType in SupModuleList:
                                    SupModuleList.remove(ModuleType)

Function ConvertTextFileToDictionary has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

def ConvertTextFileToDictionary(FileName, Dictionary, CommentCharacter, KeySplitCharacter, ValueSplitFlag, ValueSplitCharacter):

Avoid deeply nested control flow statements.

Open

                        if Pb.LibraryClass != []:
                            #
                            # For Library
                            #
                            for Libs in Pb.LibraryClass:

Avoid deeply nested control flow statements.

Open

                        for Node in ConsumedByList[Item]:
                            if Node not in Constructor:
                                #
                                # remove edge e from the graph
                                #

Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def __init__(self, Filename=None, IsToDatabase=False, IsToModule=False, WorkspaceDir=None, Database=None, SupArchList=DataType.ARCH_LIST):

Avoid deeply nested control flow statements.

Open

                        if CurrentSection != ItemList[0]:
                            EdkLogger.error("Parser", PARSER_ERROR, "Different section names '%s' and '%s' are found in one section definition, this is not allowed." % (CurrentSection, ItemList[0]), File=Filename, Line=LineNo, RaiseError=EdkLogger.IsRaiseError)
                    if CurrentSection.upper() not in self.KeyList:

Function GenUserExtensions has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def GenUserExtensions(self):
        UEObj = self.DecParser.GetUserExtensionSectionObject()
        UEList = UEObj.GetAllUserExtensions()
        for Item in UEList:
            if not Item.UserString:

• Read up
  Read up

Avoid deeply nested control flow statements.

Open

                        for ModuleType in SupModuleList:
                            Pb.LibraryClasses[(Item.Name, ModuleType)] = Item.FilePath

                #
                # Libraries

Avoid deeply nested control flow statements.

Open

                        if ModuleTypeInList in DT.VALID_DEPEX_MODULE_TYPE_LIST:
                            ModuleTypeList.append(ModuleTypeInList)
                if not ModuleTypeList:

Avoid deeply nested control flow statements.

Open

                        if ItemArch not in Library.Module.Header:
                            continue
                        Pb.Libraries[Library.Module.Header[ItemArch].Name] = Item.FilePath

Avoid deeply nested control flow statements.

Open

                        for Pcd in Module.PcdBuildDefinitions:
                            if (Name, Guid) == (Pcd.CName, Pcd.TokenSpaceGuidCName):
                                if Pcd.DefaultValue != '':
                                    Value = Pcd.DefaultValue
                                if Pcd.MaxDatumSize != '':

Avoid deeply nested control flow statements.

Open

                        if ItemList[1] != '' and ItemList[1].upper() not in ARCH_LIST_FULL:
                            EdkLogger.error("Parser", PARSER_ERROR, "Invalid Arch definition '%s' found" % ItemList[1], File=Filename, Line=LineNo, RaiseError=EdkLogger.IsRaiseError)
                        ArchList.append(ItemList[1].upper())

Avoid deeply nested control flow statements.

Open

                        if Value != None: break
            else:

Function InsertSectionItems has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

def InsertSectionItems(Model, CurrentSection, SectionItemList, ArchList, ThirdList, RecordSet):

Function _EqExpr has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.

Open

    def _EqExpr(self):
        Val = self._RelExpr()
        while self._IsOperator(["==", "!=", "EQ", "NE", "IN", "in", "!", "NOT", "not"]):
            Op = self._Token
            if Op in ["!", "NOT", "not"]:

• Read up
  Read up

Function ConvertTextFileToDictionary has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def ConvertTextFileToDictionary(self, FileName, Dictionary, CommentCharacter, KeySplitCharacter, ValueSplitFlag, ValueSplitCharacter):

Function ConvertTextFileToDictionary has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

def ConvertTextFileToDictionary(FileName, Dictionary, CommentCharacter, KeySplitCharacter, ValueSplitFlag, ValueSplitCharacter):

Avoid deeply nested control flow statements.

Open

                    if LibraryClassDict.has_key('COMMON'):
                        LibraryClassDict['COMMON'].append(Statement)
                    else:
                        LibraryClassDict['COMMON'] = ['## @LIB_INSTANCES']
                        LibraryClassDict['COMMON'].append(Statement)

Function GetModInPackage has 6 arguments (exceeds 4 allowed). Consider refactoring.

Open

    def GetModInPackage(self, Guid, Version, Name, Path, PkgGuid='', PkgVersion=''):