hackedteam/vector-edk

View on GitHub

Showing 9,525 of 13,510 total issues

Avoid deeply nested control flow statements.
Open

                        if not EccGlobalData.gException.IsException(ERROR_META_DATA_FILE_CHECK_PCD_TYPE, FunName):
                            if Model in [MODEL_PCD_FIXED_AT_BUILD] and not FunName.startswith('FixedPcdGet'):
                                EccGlobalData.gDb.TblReport.Insert(ERROR_META_DATA_FILE_CHECK_PCD_TYPE, OtherMsg="The pcd '%s' is defined as a FixPcd but now it is called by c function [%s]" % (PcdName, FunName), BelongsToTable=TblName, BelongsToItem=Record[1])
                            if Model in [MODEL_PCD_FEATURE_FLAG] and (not FunName.startswith('FeaturePcdGet') and not FunName.startswith('FeaturePcdSet')):
                                EccGlobalData.gDb.TblReport.Insert(ERROR_META_DATA_FILE_CHECK_PCD_TYPE, OtherMsg="The pcd '%s' is defined as a FeaturePcd but now it is called by c function [%s]" % (PcdName, FunName), BelongsToTable=TblName, BelongsToItem=Record[1])
Severity: Major
Found in BaseTools/Source/Python/Ecc/Check.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                        for Star in StarList:
                            Type = Type.strip()
                            Type = Type.rstrip(Star)
                        # Get real type after de-reference pointers.
                        if len(Type.strip()) == 0:
    Severity: Major
    Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          if len(Type.strip()) == 0:
                              Type = TypeList[-2]
                      TypedefDict = GetTypedefDict(FullFileName)
      Severity: Major
      Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                for Char in Line:
                                    IndexOfChar += 1
                                    if ord(Char) > 126:
                                        OtherMsg = "File %s has Non-ASCII char at line %s column %s" % (Record[1], IndexOfLine, IndexOfChar)
                                        EccGlobalData.gDb.TblReport.Insert(ERROR_GENERAL_CHECK_NON_ACSII, OtherMsg=OtherMsg, BelongsToTable='File', BelongsToItem=Record[0])
        Severity: Major
        Found in BaseTools/Source/Python/Ecc/Check.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                              if PredVarStr in FuncReturnTypeDict:
                                  continue
          
          Severity: Major
          Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                if EccGlobalData.gConfig.HeaderCheckCFileCommentReferenceFormat == '1' or EccGlobalData.gConfig.HeaderCheckAll == '1' or EccGlobalData.gConfig.CheckAll == '1':
                                    if RefListFlag == True:
                                        if RefLine.strip() and RefLine.strip().startswith('**/') == False and RefLine.startswith('  -') == False:                            
                                            PrintErrorMsg(ERROR_HEADER_CHECK_FILE, 'Each reference on a separate line should begin with a bullet character ""-"" ', FileTable, ID)                    
                
            Severity: Major
            Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

              Avoid deeply nested control flow statements.
              Open

                                  if Part.strip() == 'IN':
                                      InOutStr += 'in'
                                  if Part.strip() == 'OUT':
              Severity: Major
              Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                    if Part.strip() == 'OUT':
                                        if InOutStr != '':
                                            InOutStr += ', out'
                                        else:
                                            InOutStr = 'out'
                Severity: Major
                Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          if LibraryClass[1] == LibName:
                                              IsFound = True
                                      if not IsFound:
                  Severity: Major
                  Found in BaseTools/Source/Python/Ecc/Check.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                        if DiffModifier(ParamListOfDef[Index].Modifier, ParamListOfDecl[Index].Modifier) and not EccGlobalData.gException.IsException(ERROR_C_FUNCTION_LAYOUT_CHECK_FUNCTION_PROTO_TYPE_3, FuncName):
                                            PrintErrorMsg(ERROR_C_FUNCTION_LAYOUT_CHECK_FUNCTION_PROTO_TYPE_3, 'Parameter %s has different modifier with prototype in function [%s].' % (ParamListOfDef[Index].Name, FuncName), 'Function', FuncDef[3])
                                        Index += 1
                    Severity: Major
                    Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if not EccGlobalData.gException.IsException(ERROR_INCLUDE_FILE_CHECK_NAME, Path):
                                                  EccGlobalData.gDb.TblReport.Insert(ERROR_INCLUDE_FILE_CHECK_NAME, OtherMsg="The file name for [%s] is duplicate" % Path, BelongsToTable='File', BelongsToItem=Item[0])
                      
                          # Check whether all include file contents is guarded by a #ifndef statement.
                          def IncludeFileCheckIfndef(self):
                      Severity: Major
                      Found in BaseTools/Source/Python/Ecc/Check.py - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                            if TmpStr.startswith(PredVarStr):
                                                IsFuncCall = True
                        
                        Severity: Major
                        Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                              if Part.lstrip('@') not in DoxygenCommandList:
                                                  PrintErrorMsg(ERROR_DOXYGEN_CHECK_COMMAND, 'Unknown doxygen command %s' % Part, FileTable, Result[1])
                                          else:
                          Severity: Major
                          Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                            Function GetIncludeListOfFile has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                            Open

                            def GetIncludeListOfFile(WorkSpace, Filepath, Db):
                                IncludeList = []
                                Filepath = os.path.normpath(Filepath)
                                SqlCommand = """
                                            select Value1, FullPath from Inf, File where Inf.Model = %s and Inf.BelongsToFile in(
                            Severity: Minor
                            Found in BaseTools/Source/Python/Ecc/MetaDataParser.py - About 45 mins to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function StoreFunctionCalling has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def StoreFunctionCalling(self, StartLine, StartOffset, EndLine, EndOffset, FuncName, ParamList):
                            Severity: Minor
                            Found in BaseTools/Source/Python/Ecc/CParser.py - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                  if TmpStr.startswith(PredVarStr):
                                                      IsFuncCall = True
                              
                              Severity: Major
                              Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                    if PredVarStr in FuncReturnTypeDict:
                                                        continue
                                                Type = GetVarInfo(PredVarList, FuncRecord, FullFileName, IsFuncCall, 'BOOLEAN', StarList)
                                Severity: Major
                                Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                                  Avoid deeply nested control flow statements.
                                  Open

                                                      if RealCmd not in DoxygenCommandList:
                                                          PrintErrorMsg(ERROR_DOXYGEN_CHECK_COMMAND, 'Unknown doxygen command %s' % Part, FileTable, Result[1])
                                  
                                  Severity: Major
                                  Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                        if RefLine.strip() and (NextLineIndex + 1) < len(CommentStrList) and CommentStrList[NextLineIndex+1].strip() and CommentStrList[NextLineIndex+1].strip().startswith('**/') == False:
                                                            RefListFlag = True
                                                        if RefLine.strip() == False or RefLine.strip().startswith('**/'):
                                    Severity: Major
                                    Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix

                                      Avoid deeply nested control flow statements.
                                      Open

                                                          if PredVarStr in FuncReturnTypeDict:
                                                              continue
                                      
                                      Severity: Major
                                      Found in BaseTools/Source/Python/Ecc/c.py - About 45 mins to fix
                                        Severity
                                        Category
                                        Status
                                        Source
                                        Language