hackedteam/vector-exploit

View on GitHub

Showing 219 of 389 total issues

Function decrypt has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def decrypt(self, cipherIn, originalsize, mode, key, size, IV):
Severity: Minor
Found in src/edn2/2014-004-AndroidBrowser/slowaes.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if len(output)-1 < i:
                                plaintext[i] = 0 ^ ciphertext[i]
                            elif len(ciphertext)-1 < i:
                                plaintext[i] = output[i] ^ 0
                            elif len(output)-1 < i and len(ciphertext) < i:
    Severity: Major
    Found in src/edn2/2014-004-AndroidBrowser/slowaes.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if ch == '\0\0':
                                  f['filename'] = unicode(name, 'utf-16')
                                  break
                              name += ch
      Severity: Major
      Found in ht-2013-002-Word/pylzma.egg/py7zlib.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                for g in gadgets_retrieved:
        
                                    # gadget not found TODO: test 
                                    if ( len(g) > 8 or  g == 'null' ):
                                        ExploitHTTPHandler.send_empty_reply()
        Severity: Major
        Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if firstRound:
                                      plaintext[i] = IV[i] ^ output[i]
                                  else:
                                      plaintext[i] = iput[i] ^ output[i]
                              firstRound = False
          Severity: Major
          Found in src/edn2/2014-004-AndroidBrowser/slowaes.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                        if (m_data < 0x10000) {
                            INFO("find_node_40: Invalid data value for text node: " + hex(m_data, 8) +
                             " (type offset: " + i*4 + ", dataoffset: " + dataoffset);
                            return null;
                        }
            Severity: Major
            Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 45 mins to fix

              Function _read_7z_aes256_sha256 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

                  def _read_7z_aes256_sha256(self, coder, input):
                      if not self._archive.password:
                          raise NoPasswordGivenError()
                      
                      # TODO: this needs some sanity checks
              Severity: Minor
              Found in ht-2013-002-Word/pylzma.egg/py7zlib.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                  with open(apk_path, 'rb') as f:
                                      data = s.recv(1025)
                                      if(data.strip() == "ready"):
                                          time.sleep(2)
                                          logging.info('Sending file {}..'.format(apk_path))
              Severity: Major
              Found in src/ht-webkit-Android23/exp_server.py - About 45 mins to fix

                Function stage3_alternate has 6 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                function stage3_alternate(memobj, node, addr, page, libwebcore, libc) {
                Severity: Minor
                Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 45 mins to fix

                  Function xslt_exploit has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                  function xslt_exploit(iframe, xml, base, documentarea, pagenum) {
                  
                      documentarea += 56;
                      documentarea += 4;
                  
                  
                  Severity: Minor
                  Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Function parse_local_report has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                  Open

                      def parse_local_report(self, log_fd):
                          msg = {
                              'dwer':'An error occured during download!',
                              'pker':'An error occured analyzing packages on device!',
                              'expfl':'Exploitation failed!',
                  Severity: Minor
                  Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 45 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid deeply nested control flow statements.
                  Open

                                          for k in range(end-start):
                                              stringOut += chr(plaintext[k])
                                      iput = ciphertext
                  Severity: Major
                  Found in src/edn2/2014-004-AndroidBrowser/slowaes.py - About 45 mins to fix

                    Function __init__ has 6 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                        def __init__(self, ip, socket_port, final_executable,  exploit_id, landing_page, redirect_page):
                    Severity: Minor
                    Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if not candidate_port in used_socket_ports:
                                                  found = True
                      
                      
                      Severity: Major
                      Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 45 mins to fix

                        Function _read_7z_aes256_sha256 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                            def _read_7z_aes256_sha256(self, coder, input):
                                if not self._archive.password:
                                    raise NoPasswordGivenError()
                                
                                # TODO: this needs some sanity checks
                        Severity: Minor
                        Found in ht-2013-003-Powerpoint/pylzma.egg/py7zlib.py - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function findindex has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                        Open

                        ELFObject.prototype.findindex = function(name) {
                            if (this.hashtab === undefined) {
                            this.hashtab = {};
                            this.hashtab.addr = this.dyntable['hashtab'];
                            this.hashtab.nbucket = this.memobj.read32(this.hashtab.addr);
                        Severity: Minor
                        Found in src/ht-webkit-Android4-src/precompiled/debug/script.js - About 45 mins to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Avoid deeply nested control flow statements.
                        Open

                                                for k in range(originalsize-start):
                                                    stringOut += chr(plaintext[k])
                                            else:
                        Severity: Major
                        Found in src/edn2/2014-004-AndroidBrowser/slowaes.py - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                      if(data.strip() == "ready"):
                                              time.sleep(2)
                                              logging.info('Sending file {}..'.format(dw_file))
                                              data = f.read()
                                              s.sendall(data)
                          Severity: Major
                          Found in src/ht-webkit-Android23/exp_server.py - About 45 mins to fix

                            Avoid deeply nested control flow statements.
                            Open

                                                    for g in gadgets_retrieved:
                            
                                                        # gadget not found TODO: test 
                                                        if ( len(g) > 8 or  g == 'null' ):
                                                            ExploitHTTPHandler.send_empty_reply()
                            Severity: Major
                            Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      if len(gadgets_retrieved) != 9:
                                                          firstStageSuccessful = False
                                                          ExploitHTTPHandler.send_empty_reply()
                                                          
                                                          logging.debug('Not enough gadgets {} '.format( len(gadgets_retrieved) ) )
                              Severity: Major
                              Found in src/ht-webkit-Android23/webkit_rc3_plus_tea.py - About 45 mins to fix
                                Severity
                                Category
                                Status
                                Source
                                Language