hackedteam/vector-exploit

View on GitHub

Showing 219 of 389 total issues

Avoid deeply nested control flow statements.
Open

                        if len(output)-1 < i:
                            plaintext[i] = 0 ^ ciphertext[i]
                        elif len(ciphertext)-1 < i:
                            plaintext[i] = output[i] ^ 0
                        elif len(output)-1 < i and len(ciphertext) < i:
Severity: Major
Found in src/edn2/2014-004-AndroidBrowser/slowaes.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if ch == '\0\0':
                                f['filename'] = unicode(name, 'utf-16')
                                break
                            name += ch
    Severity: Major
    Found in ht-2013-003-Powerpoint/pylzma.egg/py7zlib.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if len(output)-1 < i:
                                  plaintext[i] = 0 ^ ciphertext[i]
                              elif len(ciphertext)-1 < i:
                                  plaintext[i] = output[i] ^ 0
                              elif len(output)-1 < i and len(ciphertext) < i:
      Severity: Major
      Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if len(plaintext)-1 < i:
                                    ciphertext[i] = 0 ^ output[i]
                                elif len(output)-1 < i:
                                    ciphertext[i] = plaintext[i] ^ 0
                                elif len(plaintext)-1 < i and len(output) < i:
        Severity: Major
        Found in src/ht-webkit-Android4-src/ext/slowaes.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if firstRound:
                                      iput[i] =  plaintext[i] ^ IV[i]
                                  else:
                                      iput[i] =  plaintext[i] ^ ciphertext[i]
                              # print 'IP@%s:%s' % (j, iput)
          Severity: Major
          Found in src/ht-webkit-Android4-src/ext/slowaes.py - About 45 mins to fix

            Avoid deeply nested control flow statements.
            Open

                                    if firstRound:
                                        plaintext[i] = IV[i] ^ output[i]
                                    else:
                                        plaintext[i] = iput[i] ^ output[i]
                                firstRound = False
            Severity: Major
            Found in src/ht-webkit-Android4-src/ext/slowaes.py - About 45 mins to fix

              Function main has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              def main():
              
                  parser = argparse.ArgumentParser(
                      description="Android Browser 4.0.x-4.3 remote exploit EDN build script"
                  )
              Severity: Minor
              Found in src/ht-webkit-Android4-src/src/edn_build.py - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Avoid deeply nested control flow statements.
              Open

                                      for k in range(end-start):
                                          stringOut += chr(plaintext[k])
                                  iput = ciphertext
              Severity: Major
              Found in src/ht-webkit-Android4-src/precompiled/debug/slowaes.py - About 45 mins to fix

                Avoid deeply nested control flow statements.
                Open

                                        if len(plaintext)-1 < i:
                                            ciphertext[i] = 0 ^ output[i]
                                        elif len(output)-1 < i:
                                            ciphertext[i] = plaintext[i] ^ 0
                                        elif len(plaintext)-1 < i and len(output) < i:
                Severity: Major
                Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

                  Avoid deeply nested control flow statements.
                  Open

                                          for k in range(originalsize-start):
                                              stringOut += chr(plaintext[k])
                                      else:
                  Severity: Major
                  Found in src/ht-webkit-Android4-src/precompiled/debug/slowaes.py - About 45 mins to fix

                    Avoid deeply nested control flow statements.
                    Open

                                            if firstRound:
                                                plaintext[i] = IV[i] ^ output[i]
                                            else:
                                                plaintext[i] = iput[i] ^ output[i]
                                        firstRound = False
                    Severity: Major
                    Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

                      Avoid deeply nested control flow statements.
                      Open

                                              if firstRound:
                                                  iput[i] =  plaintext[i] ^ IV[i]
                                              else:
                                                  iput[i] =  plaintext[i] ^ ciphertext[i]
                                          # print 'IP@%s:%s' % (j, iput)
                      Severity: Major
                      Found in src/ht-webkit-Android4-src/precompiled/debug/slowaes.py - About 45 mins to fix

                        Avoid deeply nested control flow statements.
                        Open

                                                if len(output)-1 < i:
                                                    plaintext[i] = 0 ^ ciphertext[i]
                                                elif len(ciphertext)-1 < i:
                                                    plaintext[i] = output[i] ^ 0
                                                elif len(output)-1 < i and len(ciphertext) < i:
                        Severity: Major
                        Found in src/ht-webkit-Android4-src/precompiled/debug/slowaes.py - About 45 mins to fix

                          Avoid deeply nested control flow statements.
                          Open

                                                  if len(plaintext)-1 < i:
                                                      ciphertext[i] = 0 ^ output[i]
                                                  elif len(output)-1 < i:
                                                      ciphertext[i] = plaintext[i] ^ 0
                                                  elif len(plaintext)-1 < i and len(output) < i:
                          Severity: Major
                          Found in src/ht-webkit-Android4-src/ext/slowaes.py - About 45 mins to fix

                            Function decrypt has 6 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                def decrypt(self, cipherIn, originalsize, mode, key, size, IV):
                            Severity: Minor
                            Found in src/ht-webkit-Android4-src/precompiled/debug/slowaes.py - About 45 mins to fix

                              Avoid deeply nested control flow statements.
                              Open

                                                      if len(plaintext)-1 < i:
                                                          ciphertext[i] = 0 ^ output[i]
                                                      elif len(output)-1 < i:
                                                          ciphertext[i] = plaintext[i] ^ 0
                                                      elif len(plaintext)-1 < i and len(output) < i:
                              Severity: Major
                              Found in src/ht-webkit-Android4-src/precompiled/debug/slowaes.py - About 45 mins to fix

                                Avoid deeply nested control flow statements.
                                Open

                                                        if len(output)-1 < i:
                                                            plaintext[i] = 0 ^ ciphertext[i]
                                                        elif len(ciphertext)-1 < i:
                                                            plaintext[i] = output[i] ^ 0
                                                        elif len(output)-1 < i and len(ciphertext) < i:
                                Severity: Major
                                Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

                                  Function _read_7z_aes256_sha256 has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
                                  Open

                                      def _read_7z_aes256_sha256(self, coder, input):
                                          if not self._archive.password:
                                              raise NoPasswordGivenError()
                                          
                                          # TODO: this needs some sanity checks
                                  Severity: Minor
                                  Found in ht-2013-004-IE/pylzma.egg/py7zlib.py - About 45 mins to fix

                                  Cognitive Complexity

                                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                                  A method's cognitive complexity is based on a few simple rules:

                                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                                  • Code is considered more complex for each "break in the linear flow of the code"
                                  • Code is considered more complex when "flow breaking structures are nested"

                                  Further reading

                                  Avoid deeply nested control flow statements.
                                  Open

                                                          if firstRound:
                                                              iput[i] =  plaintext[i] ^ IV[i]
                                                          else:
                                                              iput[i] =  plaintext[i] ^ ciphertext[i]
                                                      # print 'IP@%s:%s' % (j, iput)
                                  Severity: Major
                                  Found in src/ht-webkit-Android4-src/precompiled/release/slowaes.py - About 45 mins to fix

                                    Avoid deeply nested control flow statements.
                                    Open

                                                            if ch == '\0\0':
                                                                f['filename'] = unicode(name, 'utf-16')
                                                                break
                                                            name += ch
                                    Severity: Major
                                    Found in ht-2013-004-IE/pylzma.egg/py7zlib.py - About 45 mins to fix
                                      Severity
                                      Category
                                      Status
                                      Source
                                      Language