hairyhenderson/node-fellowshipone

View on GitHub

Showing 4 of 8 total issues

Function _req has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

F1Resource.prototype._req = function (method, path, query, body, callback) {
  var config = this.f1.config

  var opts = {
    uri: config.apiURL + path,
Severity: Minor
Found in lib/f1resource.js - About 1 hr to fix

Function _req has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

F1Resource.prototype._req = function (method, path, query, body, callback) {
  var config = this.f1.config

  var opts = {
    uri: config.apiURL + path,
Severity: Minor
Found in lib/f1resource.js - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _req has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

F1Resource.prototype._req = function (method, path, query, body, callback) {
Severity: Minor
Found in lib/f1resource.js - About 35 mins to fix

Function list has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

F1Resource.prototype.list = function (callback) {
  this._get(this.path, function (err, body, headers) {
    if (err) return callback(err)

    if (body && body[this.resourceNamePlural] && body[this.resourceNamePlural][this.resourceName]) {
Severity: Minor
Found in lib/f1resource.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language