Sign upLogin

hakimel/reveal.js

View on GitHub
Star
js/controllers/backgrounds.js

Summary

Maintainability
D
2 days
Test Coverage

Function update has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    update( includeAll = false ) {

        let config = this.Reveal.getConfig();
        let currentSlide = this.Reveal.getCurrentSlide();
        let indices = this.Reveal.getIndices();
Severity: Major
Found in js/controllers/backgrounds.js - About 3 hrs to fix

    Function sync has 63 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        sync( slide ) {

        const element = slide.slideBackgroundElement,
            contentElement = slide.slideBackgroundContentElement;
    Severity: Major
    Found in js/controllers/backgrounds.js - About 2 hrs to fix

      Function update has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          update( includeAll = false ) {

        let config = this.Reveal.getConfig();
        let currentSlide = this.Reveal.getCurrentSlide();
        let indices = this.Reveal.getIndices();
      Severity: Minor
      Found in js/controllers/backgrounds.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File backgrounds.js has 264 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      import { queryAll } from '../utils/util.js'
import { colorToRgb, colorBrightness } from '../utils/color.js'

/**
 * Creates and updates slide backgrounds.
      Severity: Minor
      Found in js/controllers/backgrounds.js - About 2 hrs to fix

        Function sync has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
        Open

            sync( slide ) {

        const element = slide.slideBackgroundElement,
            contentElement = slide.slideBackgroundContentElement;
        Severity: Minor
        Found in js/controllers/backgrounds.js - About 2 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateParallax has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
        Open

            updateParallax() {

        let indices = this.Reveal.getIndices();

        if( this.Reveal.getConfig().parallaxBackgroundImage ) {
        Severity: Minor
        Found in js/controllers/backgrounds.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function updateParallax has 37 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            updateParallax() {

        let indices = this.Reveal.getIndices();

        if( this.Reveal.getConfig().parallaxBackgroundImage ) {
        Severity: Minor
        Found in js/controllers/backgrounds.js - About 1 hr to fix

          Function getContrastClass has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
          Open

              getContrastClass( slide ) {

        const element = slide.slideBackgroundElement;

        // If this slide has a background color, we add a class that
          Severity: Minor
          Found in js/controllers/backgrounds.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

                  if( data.background || data.backgroundColor || data.backgroundGradient || data.backgroundImage || data.backgroundVideo || data.backgroundIframe ) {
            element.setAttribute( 'data-background-hash', data.background +
                                                            data.backgroundSize +
                                                            data.backgroundImage +
                                                            data.backgroundVideo +
          Severity: Major
          Found in js/controllers/backgrounds.js - About 40 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                render() {

        this.element = document.createElement( 'div' );
        this.element.className = 'backgrounds';
        this.Reveal.getRevealElement().appendChild( this.element );
            Severity: Major
            Found in js/controllers/backgrounds.js and 1 other location - About 1 hr to fix
            js/controllers/slidenumber.js on lines 19..25

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 70.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    if( !contrastColor || !colorToRgb( contrastColor ) ) {
            let computedBackgroundStyle = window.getComputedStyle( element );
            if( computedBackgroundStyle && computedBackgroundStyle.backgroundColor ) {
                contrastColor = computedBackgroundStyle.backgroundColor;
            }
            Severity: Minor
            Found in js/controllers/backgrounds.js and 1 other location - About 30 mins to fix
            js/controllers/printview.js on lines 51..56

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 45.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status