Sign upLogin

hakimel/reveal.js

View on GitHub
Star
js/controllers/fragments.js

Summary

Maintainability
D
1 day
Test Coverage

Function update has 76 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    update( index, fragments, slide = this.Reveal.getCurrentSlide() ) {

        let changedFragments = {
            shown: [],
            hidden: []
Severity: Major
Found in js/controllers/fragments.js - About 3 hrs to fix

    Function update has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

        update( index, fragments, slide = this.Reveal.getCurrentSlide() ) {

        let changedFragments = {
            shown: [],
            hidden: []
    Severity: Minor
    Found in js/controllers/fragments.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function goto has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
    Open

        goto( index, offset = 0 ) {

        let currentSlide = this.Reveal.getCurrentSlide();
        if( currentSlide && this.Reveal.getConfig().fragments ) {
    Severity: Minor
    Found in js/controllers/fragments.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sort has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        sort( fragments, grouped = false ) {

        fragments = Array.from( fragments );

        let ordered = [],
    Severity: Minor
    Found in js/controllers/fragments.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          disable() {

        queryAll( this.Reveal.getSlidesElement(), '.fragment' ).forEach( element => {
            element.classList.add( 'visible' );
            element.classList.remove( 'current-fragment' );
      Severity: Major
      Found in js/controllers/fragments.js and 1 other location - About 2 hrs to fix
      js/controllers/fragments.js on lines 47..54

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          enable() {

        queryAll( this.Reveal.getSlidesElement(), '.fragment' ).forEach( element => {
            element.classList.remove( 'visible' );
            element.classList.remove( 'current-fragment' );
      Severity: Major
      Found in js/controllers/fragments.js and 1 other location - About 2 hrs to fix
      js/controllers/fragments.js on lines 34..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 75.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if( changedFragments.shown.length ) {
            this.Reveal.dispatchEvent({
                type: 'fragmentshown',
                data: {
                    fragment: changedFragments.shown[0],
      Severity: Major
      Found in js/controllers/fragments.js and 1 other location - About 1 hr to fix
      js/controllers/fragments.js on lines 260..268

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              if( changedFragments.hidden.length ) {
            this.Reveal.dispatchEvent({
                type: 'fragmenthidden',
                data: {
                    fragment: changedFragments.hidden[0],
      Severity: Major
      Found in js/controllers/fragments.js and 1 other location - About 1 hr to fix
      js/controllers/fragments.js on lines 270..278

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 64.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status