Sign upLogin

hakimel/reveal.js

View on GitHub
Star
js/controllers/touch.js

Summary

Maintainability
F
3 days
Test Coverage

Function onTouchMove has a Cognitive Complexity of 53 (exceeds 5 allowed). Consider refactoring.
Open

    onTouchMove( event ) {

        if( this.isSwipePrevented( event.target ) ) return true;

        let config = this.Reveal.getConfig();
Severity: Minor
Found in js/controllers/touch.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function onTouchMove has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    onTouchMove( event ) {

        if( this.isSwipePrevented( event.target ) ) return true;

        let config = this.Reveal.getConfig();
Severity: Major
Found in js/controllers/touch.js - About 2 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                        if( config.navigationMode === 'linear' ) {
                        if( config.rtl ) {
                            this.Reveal.prev();
                        }
                        else {
    Severity: Major
    Found in js/controllers/touch.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              if( config.rtl ) {
                            this.Reveal.next();
                        }
                        else {
                            this.Reveal.prev();
      Severity: Major
      Found in js/controllers/touch.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                        else if( deltaY > SWIPE_THRESHOLD && availableRoutes.up ) {
                    this.touchCaptured = true;
                    if( config.navigationMode === 'linear' ) {
                        this.Reveal.prev();
                    }
        Severity: Major
        Found in js/controllers/touch.js - About 45 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          else if( deltaX < -SWIPE_THRESHOLD && Math.abs( deltaX ) > Math.abs( deltaY ) ) {
                    this.touchCaptured = true;
                    if( config.navigationMode === 'linear' ) {
                        if( config.rtl ) {
                            this.Reveal.prev();
          Severity: Major
          Found in js/controllers/touch.js and 1 other location - About 2 hrs to fix
          js/controllers/touch.js on lines 142..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 91.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          if( deltaX > SWIPE_THRESHOLD && Math.abs( deltaX ) > Math.abs( deltaY ) ) {
                    this.touchCaptured = true;
                    if( config.navigationMode === 'linear' ) {
                        if( config.rtl ) {
                            this.Reveal.next();
          Severity: Major
          Found in js/controllers/touch.js and 1 other location - About 2 hrs to fix
          js/controllers/touch.js on lines 156..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 91.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              onPointerMove( event ) {

        if( event.pointerType === event.MSPOINTER_TYPE_TOUCH || event.pointerType === "touch" )  {
            event.touches = [{ clientX: event.clientX, clientY: event.clientY }];
            this.onTouchMove( event );
          Severity: Major
          Found in js/controllers/touch.js and 1 other location - About 2 hrs to fix
          js/controllers/touch.js on lines 228..235

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              onPointerDown( event ) {

        if( event.pointerType === event.MSPOINTER_TYPE_TOUCH || event.pointerType === "touch" ) {
            event.touches = [{ clientX: event.clientX, clientY: event.clientY }];
            this.onTouchStart( event );
          Severity: Major
          Found in js/controllers/touch.js and 1 other location - About 2 hrs to fix
          js/controllers/touch.js on lines 242..249

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 87.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          else if( deltaY < -SWIPE_THRESHOLD && availableRoutes.down ) {
                    this.touchCaptured = true;
                    if( config.navigationMode === 'linear' ) {
                        this.Reveal.next();
                    }
          Severity: Major
          Found in js/controllers/touch.js and 1 other location - About 1 hr to fix
          js/controllers/touch.js on lines 170..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                          else if( deltaY > SWIPE_THRESHOLD && availableRoutes.up ) {
                    this.touchCaptured = true;
                    if( config.navigationMode === 'linear' ) {
                        this.Reveal.prev();
                    }
          Severity: Major
          Found in js/controllers/touch.js and 1 other location - About 1 hr to fix
          js/controllers/touch.js on lines 179..187

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 62.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  else if( window.navigator.msPointerEnabled ) {
            // IE 10 uses prefixed version of pointer events
            revealElement.addEventListener( 'MSPointerDown', this.onPointerDown, false );
            revealElement.addEventListener( 'MSPointerMove', this.onPointerMove, false );
            revealElement.addEventListener( 'MSPointerUp', this.onPointerUp, false );
          Severity: Major
          Found in js/controllers/touch.js and 1 other location - About 1 hr to fix
          js/controllers/touch.js on lines 38..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  if( 'onpointerdown' in window ) {
            // Use W3C pointer events
            revealElement.addEventListener( 'pointerdown', this.onPointerDown, false );
            revealElement.addEventListener( 'pointermove', this.onPointerMove, false );
            revealElement.addEventListener( 'pointerup', this.onPointerUp, false );
          Severity: Major
          Found in js/controllers/touch.js and 1 other location - About 1 hr to fix
          js/controllers/touch.js on lines 44..55

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 57.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status