hammackj/risu

View on GitHub

Showing 111 of 178 total issues

Method render has 52 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            def render output
                output.text Report.classification.upcase, :align => :center
                output.text "\n"

                report_title Report.title
Severity: Major
Found in lib/risu/templates/exec_summary.rb - About 2 hrs to fix

    Method render has 51 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                def render output
                    @output.font_size 10
    
                    report_classification
    
    
    Severity: Major
    Found in lib/risu/templates/findings_host.rb - About 2 hrs to fix

      Consider simplifying this complex logical expression.
      Open

              if nt == 0 && w2k == 0 && xp == 0 && w2k3 == 0 && vista == 0 && w2k8 == 0 && w2k12 == 0 && w7 == 0 && w8 == 0 && other == 0
                return false
              else
                return true
              end
      Severity: Critical
      Found in lib/risu/graphs/windows_os_graph.rb - About 2 hrs to fix

        Consider simplifying this complex logical expression.
        Open

                            if nt == 0 && w2k == 0 && xp == 0 && w2k3 == 0 && vista == 0 && w2k8 == 0 && w2k12 == 0 && w7 == 0 && w8 == 0 && other == 0
                                return false
                            else
                                return true
                            end
        Severity: Critical
        Found in lib/risu/models/host.rb - About 2 hrs to fix

          Method render has 48 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

                      def render output
                          text Report.classification.upcase, :align => :center
                          text "\n"
          
                          report_title Report.title
          Severity: Minor
          Found in lib/risu/templates/pci_compliance.rb - About 1 hr to fix

            Method render has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                        def render output
                            text Report.classification.upcase, :align => :center
                            text "\n"
            
                            report_title Report.title
            Severity: Minor
            Found in lib/risu/templates/assets.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method render has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                        def render output
                            output.text Report.classification.upcase, :align => :center
                            output.text "\n"
            
                            output.font_size(22) do
            Severity: Minor
            Found in lib/risu/templates/missing_root_causes.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method exploitablity_matrix has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
            Open

                            def exploitablity_matrix findings
                                results = Array.new
            
                                findings.each do |item|
                                    plugin = Plugin.where(:id => item.plugin_id).first
            Severity: Minor
            Found in lib/risu/models/item.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method initialize has 47 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                                def initialize
                                    @info =
                                    {
                                        :description => "Oracle Database Patch Rollup",
                                        :plugin_id => -99993,
            Severity: Minor
            Found in lib/risu/parsers/nessus/postprocess/oracle_database.rb - About 1 hr to fix

              Method end_report_item has 46 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                              def end_report_item(_)
                                  @ri.update(:plugin_output => @vals["plugin_output"],
                                      :plugin_name => @vals["plugin_name"],
                                      :cm_compliance_info => @vals["cm:compliance-info"],
                                      :cm_compliance_actual_value => @vals["cm:compliance-actual-value"],
              Severity: Minor
              Found in lib/risu/parsers/nessus/nessus_sax_listener.rb - About 1 hr to fix

                Method initialize has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                                    def initialize
                                        @info =
                                        {
                                            :description => "Apache Patch Rollup",
                                            :plugin_id => -99986,
                Severity: Minor
                Found in lib/risu/parsers/nessus/postprocess/apache.rb - About 1 hr to fix

                  Method initialize has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                                      def initialize
                                          @info =
                                          {
                                              :description => "Apple QuickTime Patch Rollup",
                                              :plugin_id => -99973,
                  Severity: Minor
                  Found in lib/risu/parsers/nessus/postprocess/apple_quicktime.rb - About 1 hr to fix

                    Method generate has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
                    Open

                                def generate
                                    begin
                                        template = @template
                                        template_manager = @template_manager
                    
                    
                    Severity: Minor
                    Found in lib/risu/base/templater.rb - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method render has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                                def render output
                                    text Report.classification.upcase, :align => :center
                                    text "\n"
                    
                                    report_title Report.title
                    Severity: Minor
                    Found in lib/risu/templates/top_25.rb - About 1 hr to fix

                      Consider simplifying this complex logical expression.
                      Open

                                          if linux == 0 &&
                                              osx == 0 &&
                                              freebsd == 0 &&
                                              netbsd == 0 &&
                                              cisco == 0 &&
                      Severity: Critical
                      Found in lib/risu/models/host.rb - About 1 hr to fix

                        Method migrate has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                                    def migrate direction
                                        begin
                                            if @database["adapter"] == nil
                                                return false, "[!] Invalid database adapter, please check your configuration file"
                                            end
                        Severity: Minor
                        Found in lib/risu/cli/application.rb - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method load_config has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                                    def load_config file=CONFIG_FILE, in_memory_config=false
                                        if File.exist?(file) == true or in_memory_config == true
                                            begin
                                                if in_memory_config
                                                    yaml = YAML::load(file)
                        Severity: Minor
                        Found in lib/risu/cli/application.rb - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method db_connect has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                        Open

                                    def db_connect
                                        begin
                                            if @database["adapter"] == nil
                                                puts "[!] #{@database['adapter']}" if @options[:debug]
                        
                        
                        Severity: Minor
                        Found in lib/risu/cli/application.rb - About 1 hr to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Method initialize has 39 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                            def initialize
                                                @info =
                                                {
                                                    :description => "Adobe Shockwave Player Patch Rollup",
                                                    :plugin_id => -99991,
                        Severity: Minor
                        Found in lib/risu/parsers/nessus/postprocess/adobe_shockwave_player.rb - About 1 hr to fix

                          Method render has 38 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                      def render output
                                          output.text Report.classification.upcase, :align => :center
                                          output.text "\n"
                          
                                          output.font_size(22) { output.text Report.title, :align => :center }
                          Severity: Minor
                          Found in lib/risu/templates/ms_wsus_findings.rb - About 1 hr to fix
                            Severity
                            Category
                            Status
                            Source
                            Language