Sign upLogin

haraka/haraka-plugin-ldap

View on GitHub
Star

Showing 6 of 14 total issues

Function _resolve_dn_to_alias has 45 lines of code (exceeds 25 allowed). Consider refactoring.
Open

exports._resolve_dn_to_alias = (dn, callback, connection) => {
    const pool = connection.server.notes.ldappool;
    if (!pool) {
        return onError('LDAP Pool not found!');
    }
Severity: Minor
Found in aliases.js - About 1 hr to fix

    Function _get_alias has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports._get_alias = function (address, callback, connection) {
    const pool = connection.server.notes.ldappool;
    if (!pool) {
        return onError('LDAP Pool not found!');
    }
    Severity: Minor
    Found in aliases.js - About 1 hr to fix

      Function _verify_address has 28 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      exports._verify_address = function (uid, address, callback, connection) {
    const pool = connection.server.notes.ldappool;
    const onError = (err) => {
        connection.logerror(`Could not verify address ${address}  for UID ${uid}`)
        connection.logdebug(`${util.inspect(err)}`);
      Severity: Minor
      Found in authz.js - About 1 hr to fix

        Function _verify_existence has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        exports._verify_existence = function (address, callback, connection) {
    const pool = connection.server.notes.ldappool;
    function onError (err) {
        connection.logerror(`Could not verify address ${address}`)
        connection.logdebug(`${util.inspect(err)}`);
        Severity: Minor
        Found in rcpt_to.js - About 1 hr to fix

          Function _get_dn_for_uid has 28 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

          exports._get_dn_for_uid = function (uid, callback, connection) {
    const pool = connection.server.notes.ldappool;
    function onError (err) {
        connection.logerror(`Could not get DN for UID ${uid}`)
        connection.logdebug(`: ${util.inspect(err)}`);
          Severity: Minor
          Found in authn.js - About 1 hr to fix

            Function check_plain_passwd_dn has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            exports.check_plain_passwd_dn = function (connection, user, passwd, cb) {
    connection.logdebug(`Looking up user ${ util.inspect(user) } by DN.`);

    let iter = 0
    let cbCalled = false
            Severity: Minor
            Found in authn.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language