Sign upLogin

haraka/haraka-plugin-limit

View on GitHub
Star

Showing 2 of 4 total issues

Function register has 53 lines of code (exceeds 50 allowed). Consider refactoring.
Open

exports.register = function () {
  this.inherits('haraka-plugin-redis')

  this.load_limit_ini()
  let needs_redis = 0
Severity: Major
Found in index.js - About 1 hr to fix

    Function get_host_key has a Cognitive Complexity of 20 (exceeds 15 allowed). Consider refactoring.
    Open

    exports.get_host_key = function (type, connection) {
  if (!this.cfg[type]) {
    connection.results.add(this, { err: `${type}: not configured` })
    return
  }
    Severity: Minor
    Found in index.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language