haraka/haraka-plugin-recipient-routes

View on GitHub

Showing 2 of 2 total issues

Function get_mx has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

exports.get_mx = async function (next, hmail, domain) {

  // get email address
  let address = domain.toLowerCase();
  if (hmail && hmail.todo && hmail.todo.rcpt_to && hmail.todo.rcpt_to[0]) {
Severity: Minor
Found in index.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function load_rcpt_to_routes_ini has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

exports.load_rcpt_to_routes_ini = function () {
  const plugin = this;
  plugin.cfg = plugin.config.get('rcpt_to.routes.ini', function () {
    plugin.load_rcpt_to_routes_ini();
  })
Severity: Minor
Found in index.js - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language