Sign upLogin

hardpixel/smart-pagination

View on GitHub
Star

Showing 4 of 4 total issues

Class Renderer has 28 methods (exceeds 20 allowed). Consider refactoring.
Open

  class Renderer
    def initialize(context, collection, options = {})
      @context    = context
      @collection = collection
      @options    = default_options.merge(options)
Severity: Minor
Found in lib/smart_pagination/renderer.rb - About 3 hrs to fix

    Method page_numbers has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def page_numbers
      inner = @options[:inner_window].to_i
      outer = @options[:outer_window].to_i
      from  = current_page - inner
      to    = current_page + inner
    Severity: Minor
    Found in lib/smart_pagination/renderer.rb - About 1 hr to fix

      Method page_numbers has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def page_numbers
      inner = @options[:inner_window].to_i
      outer = @options[:outer_window].to_i
      from  = current_page - inner
      to    = current_page + inner
      Severity: Minor
      Found in lib/smart_pagination/renderer.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method link_options has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def link_options(page)
      if page.is_a? Integer
        active = @options[:active_class] if current_page? page
        { class: "#{@options[:item_class]} #{active}".strip }
      else
      Severity: Minor
      Found in lib/smart_pagination/renderer.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language