Sign upLogin

harella1/video.js

View on GitHub
Star
src/js/tech/tech.js

Summary

Maintainability
F
3 days
Test Coverage

File tech.js has 405 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/**
 * @file tech.js
 * Media Technology Controller - Base class for media playback
 * technology controllers like Flash and HTML5
 */
Severity: Minor
Found in src/js/tech/tech.js - About 5 hrs to fix

    Function withSourceHandlers has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
    Open

    Tech.withSourceHandlers = function(_Tech){
   /*
    * Register a source handler
    * Source handlers are scripts for handling specific formats.
    * The source handler pattern is used for adaptive formats (HLS, DASH) that
    Severity: Minor
    Found in src/js/tech/tech.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Tech has 34 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Tech extends Component {

  constructor(options={}, ready=function(){}){
    // we don't want the tech to report user activity automatically.
    // This is done manually in addControlsListeners
    Severity: Minor
    Found in src/js/tech/tech.js - About 4 hrs to fix

      Function withSourceHandlers has 95 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      Tech.withSourceHandlers = function(_Tech){
   /*
    * Register a source handler
    * Source handlers are scripts for handling specific formats.
    * The source handler pattern is used for adaptive formats (HLS, DASH) that
      Severity: Major
      Found in src/js/tech/tech.js - About 3 hrs to fix

        Function emulateTextTracks has 36 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          emulateTextTracks() {
    let tracks = this.textTracks();
    if (!tracks) {
      return;
    }
        Severity: Minor
        Found in src/js/tech/tech.js - About 1 hr to fix

          Function constructor has 27 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            constructor(options={}, ready=function(){}){
    // we don't want the tech to report user activity automatically.
    // This is done manually in addControlsListeners
    options.reportTouchActivity = false;
    super(null, options, ready);
          Severity: Minor
          Found in src/js/tech/tech.js - About 1 hr to fix

            Function emulateTextTracks has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
            Open

              emulateTextTracks() {
    let tracks = this.textTracks();
    if (!tracks) {
      return;
    }
            Severity: Minor
            Found in src/js/tech/tech.js - About 55 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function createTrackHelper has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

            var createTrackHelper = function(self, kind, label, language, options={}) {
            Severity: Minor
            Found in src/js/tech/tech.js - About 35 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                static getTech(name) {
    if (Tech.techs_ && Tech.techs_[name]) {
      return Tech.techs_[name];
    }
              Severity: Major
              Found in src/js/tech/tech.js and 1 other location - About 3 hrs to fix
              src/js/component.js on lines 1400..1409

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 96.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status