Sign upLogin

hello-gem/hello

View on GitHub
Star

Showing 2 of 310 total issues

Avoid too many return statements within this method.
Open

          return nil unless model.active_token_or_destroy
Severity: Major
Found in lib/hello/request_manager/stateless.rb - About 30 mins to fix

Method parse has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

      def parse(user_agent_string)
        obj = user_agent_parser.parse(user_agent_string)
        a_browser = obj.to_s
        a_os = obj.os.to_s
        a_browser = "#{obj.name} #{obj.version && obj.version.major}".strip
Severity: Minor
Found in lib/hello/utils/device_name.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language