Sign upLogin

heroku/heroku-apps

View on GitHub
Star
src/commands/keys/add.js

Summary

Maintainability
C
7 hrs
Test Coverage

Function run has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

async function run (context, heroku) {
  const inquirer = require('inquirer')
  function confirmPrompt (message) {
    if (process.stdin.isTTY) {
      return inquirer.prompt([{
Severity: Minor
Found in src/commands/keys/add.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function run has 65 lines of code (exceeds 25 allowed). Consider refactoring.
Open

async function run (context, heroku) {
  const inquirer = require('inquirer')
  function confirmPrompt (message) {
    if (process.stdin.isTTY) {
      return inquirer.prompt([{
Severity: Major
Found in src/commands/keys/add.js - About 2 hrs to fix

    Function findKey has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      let findKey = async function () {
    const defaultKey = path.join(sshdir, 'id_rsa.pub')
    if (!(await fs.pathExists(defaultKey))) {
      cli.console.error('Could not find an existing SSH key at ~/.ssh/id_rsa.pub')
    Severity: Minor
    Found in src/commands/keys/add.js - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

            return resp.key
      Severity: Major
      Found in src/commands/keys/add.js - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status