Sign upLogin

heroku/heroku-pg

View on GitHub
Star
lib/util.js

Summary

Maintainability
B
4 hrs
Test Coverage

Function presentCredentialAttachments has 36 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function presentCredentialAttachments (app, credAttachments, credentials, cred) {
  let isForeignApp = (attOrAddon) => attOrAddon.app.name !== app
  let atts = sortBy(credAttachments,
    isForeignApp,
    'name',
Severity: Minor
Found in lib/util.js - About 1 hr to fix

    Function configVarNamesFromValue has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

    exports.configVarNamesFromValue = (config, value) => {
  let keys = []
  for (let key of Object.keys(config)) {
    let configVal = config[key]
    if (configVal === value) {
    Severity: Minor
    Found in lib/util.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function getConnectionDetails has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    exports.getConnectionDetails = function (attachment, config) {
  const url = require('url')
  const configVars = attachment.config_vars.filter((cv) => {
    return config[cv] && config[cv].startsWith('postgres://')
  })
    Severity: Minor
    Found in lib/util.js - About 1 hr to fix

      Function presentCredentialAttachments has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

      function presentCredentialAttachments (app, credAttachments, credentials, cred) {
  let isForeignApp = (attOrAddon) => attOrAddon.app.name !== app
  let atts = sortBy(credAttachments,
    isForeignApp,
    'name',
      Severity: Minor
      Found in lib/util.js - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status