Sign upLogin

hexlet-codebattle/codebattle

View on GitHub
Star
services/app/apps/codebattle/assets/js/widgets/lib/player.js

Summary

Maintainability
D
2 days
Test Coverage

Function reduceOriginalRecords has 138 lines of code (exceeds 25 allowed). Consider refactoring.
Open

const reduceOriginalRecords = (acc, record, index) => {
  const {
    players, records, chat: chatState, type: playbookType,
  } = acc;
  const { messages, users } = chatState;
Severity: Major
Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 5 hrs to fix

    File player.js has 297 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    import find from 'lodash/find';
import partition from 'lodash/partition';
import Delta from 'quill-delta';

import PlaybookStatusCodes from '../config/playbookStatusCodes';
    Severity: Minor
    Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 3 hrs to fix

      Function collectFinalRecord has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      const collectFinalRecord = (acc, strRecord) => {
  const record = parse(strRecord);
  const { players } = acc;

  let player;
      Severity: Minor
      Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 1 hr to fix

        Function reduceOriginalRecords has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

        const reduceOriginalRecords = (acc, record, index) => {
  const {
    players, records, chat: chatState, type: playbookType,
  } = acc;
  const { messages, users } = chatState;
        Severity: Minor
        Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this function.
        Open

            return { ...acc, players: newPlayers, records: [...records, newRecord] };
        Severity: Major
        Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return { ...acc, chat: newChatState, records: [...records, newRecord] };
          Severity: Major
          Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                return { ...acc, chat: newChatState, records: [...records, newRecord] };
            Severity: Major
            Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                  return { ...acc, players: newPlayers, records: [...records, newRecord] };
              Severity: Major
              Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                  return { ...acc, records: [...records, newRecord] };
                Severity: Major
                Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js - About 30 mins to fix

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (type === 'give_up') {
    const newPlayers = updatePlayersGameResult(
      players,
      { id: record.id, gameResult: 'gave_up' },
      { gameResult: 'won' },
                  Severity: Major
                  Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js and 1 other location - About 3 hrs to fix
                  services/app/apps/codebattle/assets/js/widgets/lib/player.js on lines 225..238

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 108.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  Similar blocks of code found in 2 locations. Consider refactoring.
                  Open

                    if (type === 'game_over') {
    const newPlayers = updatePlayersGameResult(
      players,
      { id: record.id, gameResult: 'won' },
      { gameResult: 'lost' },
                  Severity: Major
                  Found in services/app/apps/codebattle/assets/js/widgets/lib/player.js and 1 other location - About 3 hrs to fix
                  services/app/apps/codebattle/assets/js/widgets/lib/player.js on lines 210..223

                  Duplicated Code

                  Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                  Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                  When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                  Tuning

                  This issue has a mass of 108.

                  We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                  The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                  If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                  See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                  Refactorings

                  Further Reading

                  There are no issues that match your filters.

                  Category
                  Status