Showing 46 of 87 total issues
Method start
has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring. Open
def start(args = {})
default_args= {:issue_id => nil, :comments => nil, :activity_id => nil, :project_id => nil}
args = default_args.merge(args)
@time_tracker = get_current
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method stop
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
def stop
# due to the only_one_tracker validation we only could stop the active tracker
if self.valid?
# saving an TimeLog and destroying the TimeTracker have to be executed as a transaction, because we don't want to
# track all time without any data loss.
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method delete
has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring. Open
def delete
if help.permission_checker([:tt_edit_own_time_logs, :tt_edit_time_logs], {}, true)
time_logs = TimeLog.where(:id => params[:time_log_ids]).all
time_logs.each do |item|
if item.user == User.current && User.current.allowed_to_globally?(:tt_edit_own_time_logs, {}) || User.current.allowed_to_globally?(:tt_edit_time_logs, {})
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Class TimeBooking
has 21 methods (exceeds 20 allowed). Consider refactoring. Open
class TimeBooking < ActiveRecord::Base
include Redmine::I18n
attr_accessible :started_on, :stopped_at, :time_entry_id, :time_log_id, :project, :project_id, :comments, :issue, :activity_id
belongs_to :project
Method stop
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
def stop
@time_tracker = get_current
if @time_tracker.new_record?
flash[:error] = l(:no_time_tracker_running)
unless request.xhr?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method sql_for_tt_start_date_field
has 47 lines of code (exceeds 25 allowed). Consider refactoring. Open
def sql_for_tt_start_date_field(field, operator, value)
start_date = "DATE(#{self.queried_class.table_name}.started_on)"
case operator
when "="
"#{start_date} = '#{Time.parse(value[0]).to_date}'"
Method time_string2hour
has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring. Open
def time_string2hour(str)
sec = 0
if str.match(/\d\d?:\d\d?:\d\d?/) #parse general input form hh:mm:ss
arr = str.strip.split(':')
sec = arr[0].to_i * 3600 + arr[1].to_i * 60 + arr[2].to_i
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method fetch_chart_data
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def fetch_chart_data
@chart_data = Array.new
@chart_ticks = Array.new
@highlighter_data = Array.new
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method start
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
def start(args = {})
default_args= {:issue_id => nil, :comments => nil, :activity_id => nil, :project_id => nil}
args = default_args.merge(args)
@time_tracker = get_current
Method delete
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
def delete
if help.permission_checker([:tt_edit_own_bookings, :tt_edit_bookings], {}, true)
time_bookings = TimeBooking.where(:id => params[:time_booking_ids]).all
time_bookings.each do |item|
if item.user == User.current && User.current.allowed_to?(:tt_edit_own_bookings, item.project) || User.current.allowed_to?(:tt_edit_bookings, item.project)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has 31 lines of code (exceeds 25 allowed). Consider refactoring. Open
def index
@time_tracker = get_current_time_tracker
@limit = 15 # limit for both lists
Method stop
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
def stop
@time_tracker = get_current
if @time_tracker.new_record?
flash[:error] = l(:no_time_tracker_running)
unless request.xhr?
Method update
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def update
@time_tracker = get_current
unless @time_tracker.new_record?
@time_tracker.update_attributes!(params[:time_tracker])
flash[:notice] = l(:update_time_tracker_success)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method auth_values
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def auth_values
add_available_filter 'tt_start_date', :type => :date, :order => 2
add_available_filter 'tt_booking_issue', :type => :list, :order => 4, :values => Issue.visible.all.collect { |s| [s.subject, s.id.to_s] }
add_available_filter 'tt_booking_activity', :type => :list, :order => 4, :values => help.shared_activities.map { |s| [s.name, s.name] }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method logs
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def logs(options={})
group_by_order = group_by_sort_order.is_a?(Array) ? group_by_sort_order.join(',').strip : (group_by_sort_order || '').strip
options[:order].unshift group_by_order unless options[:order].map { |opt| opt.gsub('asc', '').gsub('desc', '').strip }.include? group_by_order.gsub('asc', '').gsub('desc', '').strip
order_option = options[:order].reject { |s| s.blank? }.join(',')
order_option = nil if order_option.blank?
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def index
query_from_id
time_bookings_query
unless User.current.allowed_to_globally?(:tt_edit_bookings, {})
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def index
@time_tracker = get_current_time_tracker
@limit = 15 # limit for both lists
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def index
query_from_id
time_logs_query
unless User.current.allowed_to_globally?(:tt_edit_time_logs, {})
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method auth_values
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def auth_values
add_available_filter 'tt_start_date', :type => :date, :order => 2
add_available_filter 'tt_booking_issue', :type => :list, :order => 4, :values => Issue.visible.all.collect { |s| [s.subject, s.id.to_s] }
add_available_filter 'tt_booking_activity', :type => :list, :order => 4, :values => help.shared_activities.map { |s| [s.name, s.name] }
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method add_booking
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def add_booking(args = {})
default_args = {:started_on => self.started_on, :stopped_at => self.stopped_at, :comments => self.comments, :activity_id => args[:activity_id], :issue => nil, :spent_time => nil, :project_id => self.project_id}
args = default_args.merge(args)
# TODO check time boundaries
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"