Sign upLogin

hirakiuc/tinybucket

View on GitHub
Star

Showing 4 of 17 total issues

Class Repository has 27 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Repository < Base
      include Tinybucket::Model::Concerns::RepositoryKeys

      acceptable_attributes \
        :scm, :has_wiki, :description, :links, :updated_on,
Severity: Minor
Found in lib/tinybucket/model/repository.rb - About 3 hrs to fix

    Method inject_repo_keys has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

              def inject_repo_keys(result)
            case result
            when Tinybucket::Model::Page
              result.items.map do |m|
                next unless m.class.concern_included?(:RepositoryKeys)
    Severity: Minor
    Found in lib/tinybucket/model/concerns/repository_keys.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method request has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def request(method, path, params, parser, options)
      conn = connection(parser, options)

      path = (conn.path_prefix + path).gsub(%r{//}, '/') \
        if conn.path_prefix != '/'
    Severity: Minor
    Found in lib/tinybucket/request.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method request has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def request(method, path, params, parser, options)
    Severity: Minor
    Found in lib/tinybucket/request.rb - About 35 mins to fix
      Severity
      Category
      Status
      Source
      Language