hirura/hrr_rb_ssh

View on GitHub

Showing 83 of 169 total issues

Method conditional_definition has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def conditional_definition message
      return [] unless self.class.const_defined? :CONDITIONAL_DEFINITION
      message.inject([]){ |a, (k,v)|
        field_name  = k
        field_value = if v.instance_of? ::Proc then v.call else v end
Severity: Minor
Found in lib/hrr_rb_ssh/codable.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method deq has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def deq
      begin
        Timeout.timeout(0.1) do
          __deq__
        end
Severity: Minor
Found in lib/hrr_rb_ssh/compat/ruby/queue.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method shell has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def shell env: {}
      log_info { "start shell" }
      begin
        log_info { "Opning channel" }
        channel = @connection.request_channel_open "session"
Severity: Minor
Found in lib/hrr_rb_ssh/client.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language