Sign upLogin

hlfcoding/HLFMapViewController

View on GitHub
Star

Showing 5 of 18 total issues

File MapViewController.swift has 443 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import CoreLocation
import MapKit
import UIKit

@objc(HLFMapViewControllerDelegate)
Severity: Minor
Found in Pod/Classes/MapViewController.swift - About 6 hrs to fix

    MapViewController has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

    @objc(HLFMapViewController)
open class MapViewController: UIViewController {

    open static var bundle: Bundle { return Bundle(for: self) }
    Severity: Minor
    Found in Pod/Classes/MapViewController.swift - About 2 hrs to fix

      Function mapView has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          open func mapView(_ mapView: MKMapView, regionDidChangeAnimated animated: Bool) {
        if isDeferringSelection {
            performDeferredSelection(animated: animated)
        } else if shouldRedoSearchOnPan {
            guard !hasSelectedPin && !isQuerying else { return }
      Severity: Minor
      Found in Pod/Classes/MapViewController.swift - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function mapView has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          open func mapView(_ mapView: MKMapView, annotationView view: MKAnnotationView,
                      calloutAccessoryControlTapped control: UIControl) {
        guard let button = control as? UIButton else { return }
        guard let view = view as? MapPinView else { return }
        let mapItem = MKMapItem(placemark: view.placemark)
      Severity: Minor
      Found in Pod/Classes/MapViewController.swift - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function searchMapItems has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          @objc fileprivate func searchMapItems() {
        let search = MKLocalSearch(request: searchRequest)
        search.start { [unowned self] (searchResponse, error) in
            guard let mapItems = searchResponse?.mapItems else {
                print("MKLocalSearch error: \(String(describing: error))")
      Severity: Minor
      Found in Pod/Classes/MapViewController.swift - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language