Sign upLogin

hnhdigital-os/laravel-dynamic-filter

View on GitHub
Star
js/search.js

Summary

Maintainability
D
1 day
Test Coverage

File search.js has 351 lines of code (exceeds 250 allowed). Consider refactoring.
Open


$(document).ready(function() {

    /* User clicks the availablle filters */
    var track_filters = 0;
Severity: Minor
Found in js/search.js - About 4 hrs to fix

    Function update has 60 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        update: function(search_table_id, response)
    {

        if (typeof response.rows != 'undefined') {
            toastr.remove();
    Severity: Major
    Found in js/search.js - About 2 hrs to fix

      Function update has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
      Open

          update: function(search_table_id, response)
    {

        if (typeof response.rows != 'undefined') {
            toastr.remove();
      Severity: Minor
      Found in js/search.js - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function getFilters has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          getFilters: function(search_table_id)
    {
        var current_filters = {
          'filters': {}
        };
      Severity: Minor
      Found in js/search.js - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $('.common-module-content-search').on('click', '.action-apply-filter', function(e) {
      var search_table_id = $(this).parents('.common-module-content-search').attr('id');
      $('#'+search_table_id+'-form button[type=submit]').trigger('click');
    });
        Severity: Major
        Found in js/search.js and 1 other location - About 2 hrs to fix
        js/search.js on lines 126..129

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            $('.common-module-content-search').on('click', '.action-change-filter', function(e) {
      var search_table_id = $(this).parents('.common-module-content-search').attr('id');
      $('#'+search_table_id+'-tab2').tab('show');
    });
        Severity: Major
        Found in js/search.js and 1 other location - About 2 hrs to fix
        js/search.js on lines 120..123

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 77.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (response.right_arrow) {
                $('#'+search_table_id+' .search-result-down').addClass('btn-primary btn-outline');
                $('#'+search_table_id+' .search-result-last').addClass('btn-primary btn-outline');
                $('#'+search_table_id+' .search-result-last').data('change-page', response.search.paginate_last_page);
                has_search = true;
        Severity: Minor
        Found in js/search.js and 1 other location - About 45 mins to fix
        js/search.js on lines 356..363

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                    if (response.left_arrow) {
                $('#'+search_table_id+' .search-result-up').addClass('btn-primary btn-outline');
                $('#'+search_table_id+' .search-result-first').addClass('btn-primary btn-outline');
                has_search = true;
            } else {
        Severity: Minor
        Found in js/search.js and 1 other location - About 45 mins to fix
        js/search.js on lines 367..375

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 50.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status