Sign upLogin

holderdeord/hdo-transcript-search

View on GitHub
Star
webapp/src/backend/analytics.js

Summary

Maintainability
C
1 day
Test Coverage

Function topSearches has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function topSearches(params) {
    return getAnalytics()
        .then(an => {
            return an.data.ga.getAsync({
                ids: GA_ID,
Severity: Minor
Found in webapp/src/backend/analytics.js - About 1 hr to fix

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function browsers(opts) {
    return getAnalytics().then(an => {
        return an.data.ga
            .getAsync({
                ids: GA_ID,
    Severity: Major
    Found in webapp/src/backend/analytics.js and 1 other location - About 4 hrs to fix
    webapp/src/backend/analytics.js on lines 93..109

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

    function sources(opts) {
    return getAnalytics().then(an => {
        return an.data.ga
            .getAsync({
                ids: GA_ID,
    Severity: Major
    Found in webapp/src/backend/analytics.js and 1 other location - About 4 hrs to fix
    webapp/src/backend/analytics.js on lines 111..127

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 119.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status