Sign upLogin

holderdeord/hdo-transcript-search

View on GitHub
Star
webapp/src/backend/search-api.js

Summary

Maintainability
F
3 days
Test Coverage

File search-api.js has 481 lines of code (exceeds 250 allowed). Consider refactoring.
Open

/* eslint-disable camelcase */

import Promise from 'bluebird';
import LRU from 'lru-cache';
import es from './es-client';
Severity: Minor
Found in webapp/src/backend/search-api.js - About 7 hrs to fix

    Function getLixStats has 119 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        getLixStats() {
        return es
            .search({
                index: INDEX_NAME,
                type: INDEX_TYPE,
    Severity: Major
    Found in webapp/src/backend/search-api.js - About 4 hrs to fix

      Function _buildAggregationsQuery has 64 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          _buildAggregationsQuery(opts) {
        var query = this._queryFor(opts.query);

        var aggregations = {
            timeline: {
      Severity: Major
      Found in webapp/src/backend/search-api.js - About 2 hrs to fix

        Function getHitStream has 46 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            getHitStream(opts) {
        let delimiter = opts.format === 'csv' ? ',' : '\t';
        let scrollId = null;
        let tsvHeaders = TSV_HEADERS;
        if (opts.extra_fields) {
        Severity: Minor
        Found in webapp/src/backend/search-api.js - About 1 hr to fix

          Function _buildResponse has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              _buildResponse(aggResponse) {
        let personMap = this._buildPersonMap(
            aggResponse.aggregations.filteredPeople.people
        );
          Severity: Minor
          Found in webapp/src/backend/search-api.js - About 1 hr to fix

            Function getHitStream has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

                getHitStream(opts) {
        let delimiter = opts.format === 'csv' ? ',' : '\t';
        let scrollId = null;
        let tsvHeaders = TSV_HEADERS;
        if (opts.extra_fields) {
            Severity: Minor
            Found in webapp/src/backend/search-api.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    topRepresentatives: {
                            terms: {
                                field: 'name',
                                size: 20,
                                order: { avgLixScore: 'desc' },
            Severity: Major
            Found in webapp/src/backend/search-api.js and 1 other location - About 2 hrs to fix
            webapp/src/backend/search-api.js on lines 250..275

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                                    bottomRepresentatives: {
                            terms: {
                                field: 'name',
                                size: 20,
                                order: { avgLixScore: 'asc' },
            Severity: Major
            Found in webapp/src/backend/search-api.js and 1 other location - About 2 hrs to fix
            webapp/src/backend/search-api.js on lines 223..248

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 94.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                            timeline: {
                                    date_histogram: {
                                        field: 'time',
                                        interval: 'year',
                                        time_zone: 'Europe/Oslo',
            Severity: Major
            Found in webapp/src/backend/search-api.js and 1 other location - About 1 hr to fix
            webapp/src/backend/search-api.js on lines 277..293

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

                                    timeline: {
                            date_histogram: {
                                field: 'time',
                                interval: 'year',
                                time_zone: 'Europe/Oslo',
            Severity: Major
            Found in webapp/src/backend/search-api.js and 1 other location - About 1 hr to fix
            webapp/src/backend/search-api.js on lines 203..219

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 60.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    let people = this._calculatePercentages(
            this._parseAggregation(aggResponse.aggregations.filteredPeople.people),
            this._parseAggregation(aggResponse.aggregations.people)
        );
            Severity: Minor
            Found in webapp/src/backend/search-api.js and 1 other location - About 35 mins to fix
            webapp/src/backend/search-api.js on lines 371..374

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    let parties = this._calculatePercentages(
            this._parseAggregation(aggResponse.aggregations.filteredParties.parties),
            this._parseAggregation(aggResponse.aggregations.parties)
        ).filter(e => Parties.isCurrent(e.key));
            Severity: Minor
            Found in webapp/src/backend/search-api.js and 1 other location - About 35 mins to fix
            webapp/src/backend/search-api.js on lines 345..348

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 46.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status