Sign upLogin

hopsoft/field_mapper

View on GitHub
Star

Showing 29 of 29 total issues

Avoid too many return statements within this method.
Open

        when "Float"                        then return value.to_f
Severity: Major
Found in lib/field_mapper/standard/field.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

            when "FieldMapper::Types::Plat"     then return plat_instance(type, value)
    Severity: Major
    Found in lib/field_mapper/standard/field.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return type.type.new(unmarshal(value)) if value.is_a?(String)
      Severity: Major
      Found in lib/field_mapper/standard/field.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                    return find_raw_standard_value(custom_field, raw_custom_value)
        Severity: Major
        Found in lib/field_mapper/custom/converter.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                  when "Integer"                      then return value.to_i
          Severity: Major
          Found in lib/field_mapper/standard/field.rb - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                        return raw_custom_value.map do |single_raw_custom_value|
              find_raw_standard_value(custom_field, single_raw_custom_value)
            end
            Severity: Major
            Found in lib/field_mapper/custom/converter.rb - About 30 mins to fix

              Method add_pending_assignment_for_plat has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def add_pending_assignment_for_plat(field, value)
        pending_assignments << lambda do |descendant_plats|
          if value.is_a?(Numeric)
            plat = descendant_plats[value]
            assign_param field.name, plat unless plat.nil?
              Severity: Minor
              Found in lib/field_mapper/standard/plat.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method plat_instance has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def plat_instance(type, value)
        return value if value.is_a?(FieldMapper::Standard::Plat)
        return value if value.is_a?(Numeric)
        return value.to_i if value.is_a?(String) && value =~ /\A\d+\z/
        return type.type.new(value) if value.is_a?(Hash)
              Severity: Minor
              Found in lib/field_mapper/standard/field.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Method find_raw_custom_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
              Open

                    def find_raw_custom_value(custom_field, raw_standard_value)
        return raw_standard_value unless custom_field.has_values?

        if !custom_field.standard_field.has_values?
          custom_value = custom_field.find_value(raw_standard_value)
              Severity: Minor
              Found in lib/field_mapper/standard/converter.rb - About 25 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language