Sign upLogin

hopsoft/hero

View on GitHub
Star

Showing 2 of 2 total issues

Method add_step has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

    def add_step(*args, &block)
      if block_given?
        raise ArgumentError unless args.length == 1
        name = args.first
        step = block
Severity: Minor
Found in lib/hero/observer.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method log_step has 5 arguments (exceeds 4 allowed). Consider refactoring.
Open

    def log_step(id, step, context, options, error=nil)
Severity: Minor
Found in lib/hero/observer.rb - About 35 mins to fix
    Severity
    Category
    Status
    Source
    Language