hpi-schuelerklub/workshop-portal

View on GitHub

Showing 23 of 208 total issues

Method update_event has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def update_event(event)
    status = get_status
    if status == :acceptance
      event.set_status_notification_flag_for_applications_with_status(:accepted)
      event.acceptances_have_been_sent = true
Severity: Minor
Found in app/controllers/emails_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def create
    @profile = Profile.new(profile_params)
    @profile.user_id = current_user.id

    existing_profile = Profile.find_by(user: current_user.id)
Severity: Minor
Found in app/controllers/profiles_controller.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method phase has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

  def phase
    return :draft unless published
    return :application if published && !after_deadline?
    return :selection if published && after_deadline? && !(acceptances_have_been_sent && rejections_have_been_sent)
    return :execution if published && after_deadline? && acceptances_have_been_sent && rejections_have_been_sent
Severity: Minor
Found in app/models/event.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language