Sign upLogin

huerlisi/bookyt

View on GitHub
Star

Showing 34 of 54 total issues

Function formatMoney has 6 arguments (exceeds 4 allowed). Consider refactoring.
Open

    var formatMoney = lib.formatMoney = function(number, symbol, precision, thousand, decimal, format) {
Severity: Minor
Found in app/assets/javascripts/accounting.js - About 45 mins to fix

    Function formatColumn has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        lib.formatColumn = function(list, symbol, precision, thousand, decimal, format) {
    Severity: Minor
    Found in app/assets/javascripts/accounting.js - About 45 mins to fix

      Method footer has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def footer(sender, bank_account, vat_number, uid_number, vesr_included)
      Severity: Minor
      Found in app/prawn/debit_invoice_document.rb - About 35 mins to fix

        Method set_by_date has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def set_by_date
    return unless user_signed_in?

    return if params[:years]
        Severity: Minor
        Found in app/controllers/application_controller.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method removable_line_items_attributes has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

                def removable_line_items_attributes
          return [] unless params[:id]
          Invoice.find(params[:id]).line_items.map do |line_item|
            next if line_items_param.detect { |item| item[:id] == line_item.id }
            { id: line_item.id, _destroy: true }
        Severity: Minor
        Found in app/api/bookyt/api/invoices.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method reactivate has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def reactivate(comments = nil)
    unless state == 'canceled'
      # Cancel original amount
      bookings.build(:title => "Storno",
                     :comments => comments || "Reaktiviert",
        Severity: Minor
        Found in app/models/invoice/actions.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method copy has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def copy(payment_period)
    new_invoice = dup

    # Rebuild positions
    new_invoice.line_items = line_items.map{ |line_item| line_item.copy }
        Severity: Minor
        Found in app/models/invoice.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method build_bookings has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def build_bookings
    todo_account = Account.find_by_code('1080')
    booking = nil

    rows.each do |row|
        Severity: Minor
        Found in app/models/raiffeisen_csv_import.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method build_bookings has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          def build_bookings
    todo_account = Account.find_by_code('1080')
    booking = nil

    mt940.each do |line|
        Severity: Minor
        Found in app/models/mt940_import.rb - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid too many return statements within this method.
        Open

            return false
        Severity: Major
        Found in app/models/invoice.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return 0
          Severity: Major
          Found in app/models/line_item.rb - About 30 mins to fix

            Method parse_date has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def self.parse_date(value)
    if value.is_a?(String)
      if value.match /.*-.*-.*/
        return value
      end
            Severity: Minor
            Found in lib/parse_date.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method addressee_attributes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

                    def addressee_attributes
          return {} unless declared(params)[:type]
          if create_debit_invoice?
            {
              customer_id: params[:address_id],
            Severity: Minor
            Found in app/api/bookyt/api/invoices.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method times_to_s has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def times_to_s
    if times == 1
      if quantity == "x"
        s = ""
      elsif quantity == "overall"
            Severity: Minor
            Found in app/models/line_item.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language