hummingbird-me/hummingbird

View on GitHub
app/assets/javascripts/old/json2.js

Summary

Maintainability
C
1 day
Test Coverage

Function str has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    function str(key, holder) {

// Produce a string from holder[key].

        var i,          // The loop counter.
Severity: Major
Found in app/assets/javascripts/old/json2.js - About 2 hrs to fix

    Function parse has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            JSON.parse = function (text, reviver) {
    
    // The parse method takes a text and an optional reviver function, and returns
    // a JavaScript value if the text is a valid JSON text.
    
    
    Severity: Minor
    Found in app/assets/javascripts/old/json2.js - About 1 hr to fix

      Avoid deeply nested control flow statements.
      Open

                              if (v) {
                                  partial.push(quote(k) + (gap ? ': ' : ':') + v);
                              }
      Severity: Major
      Found in app/assets/javascripts/old/json2.js - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                    if (v !== undefined) {
                                        value[k] = v;
                                    } else {
                                        delete value[k];
                                    }
        Severity: Major
        Found in app/assets/javascripts/old/json2.js - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if (v) {
                                      partial.push(quote(k) + (gap ? ': ' : ':') + v);
                                  }
          Severity: Major
          Found in app/assets/javascripts/old/json2.js - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                        v = partial.length === 0
                            ? '{}'
                            : gap
                            ? '{\n' + gap + partial.join(',\n' + gap) + '\n' + mind + '}'
                            : '{' + partial.join(',') + '}';
            Severity: Major
            Found in app/assets/javascripts/old/json2.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/old/json2.js on lines 307..311

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                            v = partial.length === 0
                                ? '[]'
                                : gap
                                ? '[\n' + gap + partial.join(',\n' + gap) + '\n' + mind + ']'
                                : '[' + partial.join(',') + ']';
            Severity: Major
            Found in app/assets/javascripts/old/json2.js and 1 other location - About 2 hrs to fix
            app/assets/javascripts/old/json2.js on lines 346..350

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 78.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status