Sign upLogin

hummingbird-me/hummingbird

View on GitHub
Star
frontend/app/controllers/onboarding/library.js

Summary

Maintainability
C
1 day
Test Coverage

Function setLibraryRating has 34 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    setLibraryRating: function(userRating, media){

      if(media.get('libraryEntry') != null){
        this.updateLibraryEntry(media, userRating);
        return;
Severity: Minor
Found in frontend/app/controllers/onboarding/library.js - About 1 hr to fix

    Function performSearch has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      performSearch: function() {
    if (this.get('loading')) {
      Ember.run.later(this, this.performSearch, 100);
      return;
    }
    Severity: Minor
    Found in frontend/app/controllers/onboarding/library.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        animeData: function(){
    if(this.get('hasSearchTerm')){
      var self = this;
      return this.store.all('anime').filter(function(anime){
        return self.get('searchResults').contains(anime.get('id'));
      Severity: Major
      Found in frontend/app/controllers/onboarding/library.js and 1 other location - About 3 hrs to fix
      frontend/app/controllers/onboarding/library.js on lines 18..26

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        mangaData: function(){
    if(this.get('hasSearchTerm')){
      var self = this;
      return this.store.all('manga').filter(function(manga){
        return self.get('searchResults').contains(manga.get('id'));
      Severity: Major
      Found in frontend/app/controllers/onboarding/library.js and 1 other location - About 3 hrs to fix
      frontend/app/controllers/onboarding/library.js on lines 8..16

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 109.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status