Showing 419 of 859 total issues
Method sign_in_action has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def sign_in_action
unless %i(email password).none? { |x| params[x].blank? }
return error! 'Missing parameters', 400
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method index has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def index
group = Group.find(params[:group_id])
members = if params[:recent].present?
group.members.accepted.order('created_at DESC').limit(14)
else- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method create_or_update_from_hash has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def self.create_or_update_from_hash(hash)
episode = Episode.find_by(anime: hash[:anime], number: hash[:episode], season_number: hash[:season])
episode ||= Episode.find_by(anime: hash[:anime], number: hash[:episode], season_number: nil)
episode ||= Episode.new(anime: hash[:anime], number: hash[:episode], season_number: hash[:season])
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def initialize(string_or_user, opts={})
if string_or_user.is_a? String
@payload = JWT.decode(string_or_user, Token.secret)[0]
else
string_or_user = string_or_user.id if string_or_user.is_a? User- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def update
if current_user.admin? || current_member.admin?
membership_hash = params.require(:group_member).permit(:pending, :rank).to_h
elsif current_member.mod?
membership_hash = params.require(:group_member).permit(:pending).to_h- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method present_anime has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def present_anime(anime, title_language_preference)
if anime
{
id: anime.id,
mal_id: anime.mal_id,- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method update has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def update
authenticate_user!
params.require(:story).permit(:is_liked, :adult)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method find has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def self.find(params)
library_entries = LibraryEntry.where(user_id: params[:user_id]).includes(:anime, anime: :genres).references(:anime, anime: :genres)
if params[:recent]
library_entries = library_entries.where(status: ["Currently Watching", "Plan to Watch"]).order('status, last_watched DESC').page(params[:page] || 1).per(6)- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Avoid too many return statements within this function. Open
return false;Avoid too many return statements within this function. Open
return false;Avoid too many return statements within this function. Open
return -1;Avoid too many return statements within this function. Open
return true;Avoid too many return statements within this function. Open
return false;Avoid too many return statements within this function. Open
return true;Avoid too many return statements within this function. Open
if (aStack[length] == a) return bStack[length] == b;Avoid too many return statements within this function. Open
return false;Avoid too many return statements within this function. Open
return;Avoid too many return statements within this function. Open
return false;Avoid too many return statements within this function. Open
return true;Avoid too many return statements within this function. Open
return false;