hummingbird-me/kitsu-web

View on GitHub
app/components/application/user-notifications/item.js

Summary

Maintainability
C
1 day
Test Coverage
F
0%

Function link has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

  link: computed('activity', function() {
    const activity = get(this, 'activity');
    const streamId = get(this, 'group.streamId');
    const queryParams = { isQueryParams: true, values: { notification: streamId } };
    const [modelType, modelId] = get(activity, 'foreignId').split(':');
Severity: Minor
Found in app/components/application/user-notifications/item.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function link has 63 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  link: computed('activity', function() {
    const activity = get(this, 'activity');
    const streamId = get(this, 'group.streamId');
    const queryParams = { isQueryParams: true, values: { notification: streamId } };
    const [modelType, modelId] = get(activity, 'foreignId').split(':');
Severity: Major
Found in app/components/application/user-notifications/item.js - About 2 hrs to fix

    Avoid too many return statements within this function.
    Open

              return hrefTo(this, 'media-reactions', id, queryParams);
    Severity: Major
    Found in app/components/application/user-notifications/item.js - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return '#';
      Severity: Major
      Found in app/components/application/user-notifications/item.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                  return hrefTo(this, `${type}.show.${unitType}.show`, get(actor, 'slug'), get(subject, 'number'), queryParams);
        Severity: Major
        Found in app/components/application/user-notifications/item.js - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                    return hrefTo(this, 'comments', modelId, queryParams);
          Severity: Major
          Found in app/components/application/user-notifications/item.js - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return '#';
            Severity: Major
            Found in app/components/application/user-notifications/item.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return '#';
              Severity: Major
              Found in app/components/application/user-notifications/item.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                          return hrefTo(this, 'group-invite', modelId, queryParams);
                Severity: Major
                Found in app/components/application/user-notifications/item.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                          return '#';
                  Severity: Major
                  Found in app/components/application/user-notifications/item.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                            return '#';
                    Severity: Major
                    Found in app/components/application/user-notifications/item.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return hrefTo(this, 'comments', id, queryParams);
                      Severity: Major
                      Found in app/components/application/user-notifications/item.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                  return hrefTo(this, 'posts', id, queryParams);
                        Severity: Major
                        Found in app/components/application/user-notifications/item.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                  return '#';
                          Severity: Major
                          Found in app/components/application/user-notifications/item.js - About 30 mins to fix

                            Parsing error: Invalid ecmaVersion.
                            Open

                            import Component from '@ember/component';

                            For more information visit Source: http://eslint.org/docs/rules/

                            There are no issues that match your filters.

                            Category
                            Status