Sign upLogin

hummingbird-me/kitsu-web

View on GitHub
Star
app/components/stream-feed/list.js

Summary

Maintainability
C
1 day
Test Coverage
F
25%

File list.js has 296 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import Component from '@ember/component';
import { all, task } from 'ember-concurrency';
import EmberObject, { get, getProperties, set, observer } from '@ember/object';
import { inject as service } from '@ember/service';
import { isEmpty } from '@ember/utils';
Severity: Minor
Found in app/components/stream-feed/list.js - About 3 hrs to fix

    Function createPost has 46 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      createPost: task(function* (content, options) {
    const data = { content, user: get(this, 'session.account'), ...options };
    // posting on another user's profile
    if (get(this, 'user') !== undefined && get(this, 'user.id') !== get(this, 'session.account.id')) {
      set(data, 'targetUser', get(this, 'user'));
    Severity: Minor
    Found in app/components/stream-feed/list.js - About 1 hr to fix

      Function createPost has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
      Open

        createPost: task(function* (content, options) {
    const data = { content, user: get(this, 'session.account'), ...options };
    // posting on another user's profile
    if (get(this, 'user') !== undefined && get(this, 'user.id') !== get(this, 'session.account.id')) {
      set(data, 'targetUser', get(this, 'user'));
      Severity: Minor
      Found in app/components/stream-feed/list.js - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _handleRealtime has 38 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        _handleRealtime(object) {
    // handle deletion
    (get(object, 'deleted') || []).forEach(activityId => {
      let activity = get(this, 'feed').findBy('id', activityId);
      if (activity) {
      Severity: Minor
      Found in app/components/stream-feed/list.js - About 1 hr to fix

        Function didReceiveAttrs has 27 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          didReceiveAttrs() {
    this._super(...arguments);
    scheduleOnce('afterRender', () => {
      get(this, 'headTags').collectHeadTags();
    });
        Severity: Minor
        Found in app/components/stream-feed/list.js - About 1 hr to fix

          Function didReceiveAttrs has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

            didReceiveAttrs() {
    this._super(...arguments);
    scheduleOnce('afterRender', () => {
      get(this, 'headTags').collectHeadTags();
    });
          Severity: Minor
          Found in app/components/stream-feed/list.js - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                if (mediaType === 'Anime') {
        filter = {
          mediaType,
          number,
          media_id: get(media, 'id')
          Severity: Major
          Found in app/components/stream-feed/list.js and 1 other location - About 1 hr to fix
          app/routes/media/show/units/show.js on lines 16..24

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 66.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Parsing error: Invalid ecmaVersion.
          Open

          import Component from '@ember/component';
          Severity: Minor
          Found in app/components/stream-feed/list.js by eslint

          For more information visit Source: http://eslint.org/docs/rules/

          There are no issues that match your filters.

          Category
          Status