hummingbird-me/kitsu-web

View on GitHub
app/utils/get-title-field.js

Summary

Maintainability
A
1 hr
Test Coverage
A
100%

Function getTitleField has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

export function getTitleField(preference, titleLocales = {}, userLocale) {
  switch (preference) {
    case 'english':
    case 'localized':
      if (userLocale in titleLocales) return userLocale;
Severity: Minor
Found in app/utils/get-title-field.js - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

      return 'en_jp';
Severity: Major
Found in app/utils/get-title-field.js - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

          if ('en_kr' in titleLocales) return 'en_kr';
    Severity: Major
    Found in app/utils/get-title-field.js - About 30 mins to fix

      Parsing error: Invalid ecmaVersion.
      Open

      import { get } from '@ember/object';
      Severity: Minor
      Found in app/utils/get-title-field.js by eslint

      For more information visit Source: http://eslint.org/docs/rules/

      There are no issues that match your filters.

      Category
      Status